🧪 Add --plugin-dir flag registration for all tests - #943
Merged
Conversation
This adds the --plugin-dir CLI flag to the e2e test framework without implementing any test logic. This allows the Jenkins pipeline to pass the flag to all test runs without causing 'flag provided but not defined' errors. The flag is registered in: - e2e-tests/config/config.go (global variable) - e2e-tests/tests/tier0/e2e_suite_test.go (tier0 flag registration) - e2e-tests/tests/tier1/e2e_suite_test.go (tier1 flag registration) Tests that don't use the plugin directory will simply ignore the flag. Tests that need it (like MTA-819) can access it via config.PluginDir. This is a prerequisite for the BuildConfig to Shipwright plugin support, allowing the pipeline infrastructure to be in place while the full test implementation is reviewed separately.
Contributor
Author
|
/rfr |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe e2e configuration now exposes ChangesPlugin Directory Configuration
Priority: ⬇️ Low — Defer this narrow e2e test configuration change because it only registers the --plugin-dir flag for pipeline compatibility without changing test logic or existing behavior. Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to E2E tier0 and tier1 runs now accept --plugin-dir without undefined-flag failures while retaining existing behavior when the flag is omitted. No current merge-blocking risk is evident. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Test Coverage ReportTotal: 49.8% Per-package coverage
Full function-level detailsPosted by CI |
midays
changed the title
msajidmansoori12
approved these changes
Sep 8, 2026
midays
added a commit
to midays/crane
that referenced
this pull request
Sep 8, 2026
Brings in: - PR migtools#943: --plugin-dir flag registration (now in upstream) - PR migtools#901: Deprecate convert subcommand - PR migtools#897: Indirect transfer with --rclone-config-secret - Other upstream changes Conflicts resolved: - e2e-tests/tests/tier0/e2e_suite_test.go: Used main's simpler flag description - e2e-tests/tests/tier1/e2e_suite_test.go: Used main's simpler flag description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
--plugin-dirCLI flag to the e2e test framework without implementing any test logic. This is a minimal change to prevent test failures while the pipeline passes this flag.Problem
The Jenkins pipeline (after merge of migrationqe-automation MR #1450) now passes
--plugin-dirto ALL test runs:But other test branches don't have this flag registered, causing:
Solution
Register the flag in the test framework so it's available to all tests, even if they don't use it.
Changes:
e2e-tests/config/config.go: AddPluginDirglobal variablee2e-tests/tests/tier0/e2e_suite_test.go: Register--plugin-dirflage2e-tests/tests/tier1/e2e_suite_test.go: Register--plugin-dirflagImpact
config.PluginDirRelated
Summary by CodeRabbit
--plugin-dircommand-line option to configure the directory containing Crane transform plugins.