Skip to content

Use clean binary names in download server#10

Merged
mpryc merged 1 commit intooadp-1.6from
cherry-pick-clean-names-oadp-1.6
Apr 2, 2026
Merged

Use clean binary names in download server#10
mpryc merged 1 commit intooadp-1.6from
cherry-pick-clean-names-oadp-1.6

Conversation

@mpryc
Copy link
Copy Markdown

@mpryc mpryc commented Apr 1, 2026

Cherry-pick of #9 to oadp-1.6.

Summary

  • Replace versioned binary names (oadp-vmdp_${VERSION}_${os}_${arch}) with clean names (oadp-vmdp_${os}_${arch}) for direct curl/wget download
  • Switch from single sha256sum.txt to per-file .sha256 sidecar checksums
  • Add LICENSE as a downloadable file on the download server page
  • Align naming conventions with oadp-cli (binaryDir, binaryFile, discoverBinaries())
  • Simplify install instructions for clean binary names

Similar to migtools/oadp-cli#174

Replace versioned binary names (oadp-vmdp_${VERSION}_${os}_${arch})
with clean names (oadp-vmdp_${os}_${arch}) so users can directly
curl/wget binaries without version/commit hash in the filename.
Switch from single sha256sum.txt to per-file .sha256 sidecar checksums.
Add LICENSE as a downloadable file on the download server page.

Similar to migtools/oadp-cli#174

Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Michal Pryc <mpryc@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2b2bf468-4e41-44d9-a3b0-a3177df6b995

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cherry-pick-clean-names-oadp-1.6

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the approved label Apr 2, 2026
@mpryc
Copy link
Copy Markdown
Author

mpryc commented Apr 2, 2026

/override ci/prow/images

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 2, 2026

@mpryc: Overrode contexts on behalf of mpryc: ci/prow/images

Details

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mpryc, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,mpryc,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shubham-pampattiwar
Copy link
Copy Markdown
Member

/lgtm

@mpryc
Copy link
Copy Markdown
Author

mpryc commented Apr 2, 2026

/override Lint

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 2, 2026

@mpryc: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Lint

Only the following failed contexts/checkruns were expected:

  • CodeRabbit
  • Create and Push Multi-Arch Manifest
  • Lint (ubuntu-latest)
  • ci/prow/images
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override Lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mpryc
Copy link
Copy Markdown
Author

mpryc commented Apr 2, 2026

/override Lint (ubuntu-latest)

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 2, 2026

@mpryc: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • (ubuntu-latest)
  • Lint

Only the following failed contexts/checkruns were expected:

  • CodeRabbit
  • Create and Push Multi-Arch Manifest
  • Lint (ubuntu-latest)
  • ci/prow/images
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override Lint (ubuntu-latest)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mpryc mpryc merged commit ceed983 into oadp-1.6 Apr 2, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants