Skip to content

Don't move the page to Downloads for background queue changes - #62

Merged
mikaeltarquin merged 1 commit into
mainfrom
claude/download-failed-oserror-oprsq0
Oct 4, 2026
Merged

mikaeltarquin merged 1 commit into
mainfrom
claude/download-failed-oserror-oprsq0

Conversation

@mikaeltarquin

Copy link
Copy Markdown
Owner

Summary

"Show Downloads When Queued" sent the page to Activity > Downloads whenever a download appeared in the queue. That included ones the reader didn't start: picks the automatic check queued from Saved, downloads moving back to the queue to wait for a slot (which looked new), and other users' downloads. It pulled the reader off whatever page they were on, and queued downloads are now listed on Queued, not Downloads.

  • The page moves only for a download queued from it (within 30 seconds of the request). It goes to the list that shows the download: Queued while it waits, Downloads once it's under way. Background changes never move it.
  • The "queued here" mark is set before the request, because the status update can arrive first. It's cleared if the request fails.
  • A download moving back to the queue is no longer taken for a new one: no navigation, and no repeated "added to queue" toast.
  • The server's fallback for AUTO_OPEN_DOWNLOADS_SIDEBAR is now off, matching the setting's default in Settings. The setting's description says what it does now.

Testing

  • New tests for newDownloadPage: Queued vs Downloads, a re-queued download isn't new, and finishing/failing doesn't count.
  • Frontend: typecheck, oxlint, oxfmt, vitest (352).
  • Python lint/format pass. The only local test failures are environment ones that fail identically on main.
  • Not tried in the running app.

🤖 Generated with Claude Code

https://claude.ai/code/session_01V88DbAixT45r3AJsyFJchY


Generated by Claude Code

"Show Downloads When Queued" sent the page to Activity > Downloads whenever
a download appeared in the queue. That included ones the reader didn't
start: picks the automatic check queued from Saved, downloads moving back
to the queue to wait for a slot (which looked new), and other users'
downloads. It pulled the reader off whatever page they were on. And queued
downloads are listed on Queued now, not Downloads.

- The page moves only for a download queued from it (within 30 seconds of
  the request), to the list that shows it: Queued while it waits to start,
  Downloads once it's under way. Background changes never move it.
- A download moving back to the queue is no longer taken for a new one:
  no navigation, and no repeated "added to queue" toast.
- The server's fallback for the setting is off, as Settings shows it,
  rather than on when it was never saved.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V88DbAixT45r3AJsyFJchY
@mikaeltarquin
mikaeltarquin merged commit 57b0e46 into main Oct 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants