Repository navigation
fix(library): preserve distinct papers with matching titles - #304
Merged
mikamikasuki merged 2 commits intoOct 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Saving two papers with different DOIs but the same title returns success while retaining only the first paper. Use stable identifiers before the title fallback so both works remain in the Library.
Fixes #94.
What changed
Scope
Blast Radius
Imports with a shared stable identifier still reuse the existing record and its passages. An identified paper and an unidentified paper with the same title remain separate.
Verification
pytest -q tests/test_api.py, 48 passed. Literature/PDF import tests: 10 passed. Workspace analysis tests: 13 passed.scripts/test.shwas stopped after 17 failures, 41 passes and 3 skips on macOS. Its first failure also reproduces on unchanged main because Linux Bubblewrap is unavailable. Full Linux, PostgreSQL and live-model validation remain unverified.AI assistance was used for implementation and review.