Repository navigation
test: bound and clean up managed-process test lifetimes - #307
Open
Ehsan-hash wants to merge 1 commit into
Open
Ehsan-hash wants to merge 1 commit into
Ehsan-hash wants to merge 1 commit into
Conversation
Contributor
Author
|
The Linux CI run finished with 1,521 passed, 67 skipped and one failure: That failure is also present on the PR base This PR changes only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An assertion failure or Ctrl-C before the usual cancellation step can leave the test's detached supervisor and command running. This adds unconditional test cleanup and limits the busy-loop child to eight seconds, so a missed cancellation cannot consume CPU indefinitely.
The change is confined to test cleanup and its regression checks. Supervisor lifecycle behavior is a separate issue.
Validation on macOS: eight focused checks cover the original cancellation test, nested pass, assertion failure, observation timeout, Ctrl-C, interrupted start, outer-runner timeout and a child arriving during cleanup. The four affected process-test files pass 46 checks, with four Linux Bubblewrap checks deselected because that sandbox is unavailable on this host. The final supervisor/busy-child process scan is empty. Production process code and repository instructions are unchanged.
Developed with OpenAI Codex assistance and independent code review.