Repository navigation
fix(api): apply paper reviews at validated source offsets - #459
Merged
mikamikasuki merged 1 commit intoOct 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saved manuscript revision proposals can identify an exact occurrence of repeated text, but applying them currently rejects the proposal as ambiguous.
Resolve every selected edit against the original source, validate its stored character span, and apply non-overlapping edits from right to left. This preserves unselected occurrences and prevents earlier replacements from shifting later edits. Unique legacy edits without offsets, revision conflicts and generation reviews retain their existing behavior.
Validation: reproduced the original rejection through the real SQLite/API path. Both new API scenarios fail against the original function and pass with the fix. Nine affected checks also pass, covering legacy edits, generation/manual-edit protection, Files/Studio publication and writing contracts. Complete failure traces were retained. No full backend suite, browser, PostgreSQL or live model/provider run was performed for this change.
Fixes #398