Repository navigation
fix(archives): reject normalized destination collisions - #460
Merged
mikamikasuki merged 1 commit intoOct 27, 2026
Merged
mikamikasuki merged 1 commit into
mikamikasuki merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project ZIP imports and backup TAR extraction can silently overwrite an earlier file when archive names refer to the same destination. Exact duplicates, dot segments and canonically equivalent Unicode names bypass the existing case-only check.
Expand the shared destination check and use it in both preflights before creating a project or extracting backup members. Keep original names in the error and preserve existing containment, symbolic-link, archive-size and inventory checks.
Validation: reproduced all three ZIP overwrite forms through the real SQLite/API path and the TAR dot-alias overwrite through the actual unpacker. Twelve focused checks and eighteen affected checks pass, including pre-creation rollback, case/traversal/corrupt archives, valid imports and exact SQLite/data byte preservation. A producer-style TAR with directory headers also passes. The original helper/unpacker fails the new regressions.
Full backup create/restore was not verified: the unchanged offline-process guard cannot enumerate host processes under the local sandbox. No guard bypass, broader process permission, PostgreSQL, Docker, live provider or full backend-suite claim.
Fixes #395