Repository navigation
fix(statistics): reject duplicate paired CSV headers - #463
Merged
mikamikasuki merged 1 commit intoOct 27, 2026
Merged
Conversation
Contributor
Author
|
Thanks for merging these fixes, @mikamikasuki! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #405.
csv.DictReadersilently keeps the last value for a repeated header. In paired statistics this could reverse the reported comparison. Reject duplicate decoded column names before reading observations, running inference, or writing results, matching the existing paired-verification boundary.Validation:
The worker checks use independent SQLite/data/temp roots. Ambiguous input retains its exact source bytes but publishes no metrics or Analysis; the valid control retains the expected result and provenance. These checks exercise the direct worker branch, not daemon lifecycle transitions. No live provider, research experiment, PostgreSQL, browser, or full-suite validation is claimed.