Skip to content

BUG: Support \t, \r on raw usage, they are printable #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erikn69 wants to merge 1 commit into
base: development
Choose a base branch
from
Open

BUG: Support \t, \r on raw usage, they are printable #1355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Mike42/Escpos/PrintBuffers/EscposPrintBuffer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@ public function writeTextRaw(string $text)
$outp = str_repeat(self::REPLACEMENT_CHAR, $l);
for ($i = 0; $i < $l; $i++) {
$c = substr($text, $i, 1);
if ($c == "\r") {
/* Skip past Windows line endings (raw usage). */
if ($c == "\r" && substr($text, $i + 1, 1) == "\n") {
/* Skip past Windows line endings CRLF (raw usage). */
continue;
} elseif (self::asciiCheck($c, true)) {
$outp[$j] = $c;
Expand Down Expand Up @@ -296,6 +296,12 @@ private static function asciiCheck(string $char, bool $extended = false)
if ($num == 10) { // New-line (printer will take these)
return true;
}
if ($num == 13) { // Carriage-return (printer will take these)
return true;
}
if ($num == 9) { // Horizontal-tab (printer will take these)
return true;
}
if ($extended && $num > 127) {
return true;
}
Expand Down