Skip to content

.get and .put do not properly propagate auth errors  #43

Description

@RyanMarcus

It appears the .get (and presumably the .put, based on what I've seen in the code) methods do not properly pass up authentication errors. Here's a simple reproducer:

const sequest = require('sequest');

sequest.get(
    "nothing@rmarcus.info",
    "/doesntEvenMatter.txt"
).on('error', console.error);

I was about the send a PR, but I noticed that this is already fixed by PR #42 . It would be great to see this merged...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions