This repository was archived by the owner on May 25, 2020. It is now read-only.
Conversation
…ng relevant USB HID specifications. Maintain legacy support for old hidMap format, and new hidMap format of <keycode>: { unmodified: "<string value>", shift: "<shift string value>"}. This allows for uppercase and lowercase alphanumeric strings, as well as many special characters that didn't work before. The most glaring problems occurred when attempting to scan a QRcode which contained a URL.
mikerovers
self-requested a review
December 27, 2018 10:07
mikerovers
approved these changes
Dec 27, 2018
mikerovers
left a comment
mikerovers
left a comment
Owner
There was a problem hiding this comment.
Thank you for the pull request. I do not own a QR code scanner, so I can not check if that works. It works with my barcode scanner.
jie-meng
reviewed
Aug 8, 2019
| RIGHT_CTRL: 0x5, | ||
| RIGHT_SHIFT: 0x6, | ||
| RIGHT_ALT: 0x7, | ||
| RIGHT_GUI: 0x8 |
There was a problem hiding this comment.
Should be
const MODIFIER_BITS = {
LEFT_CTRL: 0x1,
LEFT_SHIFT: 0x2,
LEFT_ALT: 0x4,
LEFT_GUI: 0x8,
RIGHT_CTRL: 0x10,
RIGHT_SHIFT: 0x20,
RIGHT_ALT: 0x40,
RIGHT_GUI: 0x80,
};
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ng relevant USB HID specifications. Maintain legacy support for old hidMap format, and new hidMap format of : { unmodified: "", shift: ""}. This allows for uppercase and lowercase alphanumeric strings, as well as many special characters that didn't work before. The most glaring problems occurred when attempting to scan a QRcode which contained a URL.