Repository navigation
Fix false logout on refresh for v0.1.17 - #4
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refresh could report that a signed-in user was logged out when
codex login statusfailed with a permission error. Treat access failures as indeterminate and require an explicitNot logged inresult before reporting sign-in is needed. Snapshot loading can continue, and a failed refresh preserves stale data with the actual refresh error.Bumps the app to 0.1.17 (17). Regression coverage includes permission failures during manual preflight and timeout fallback, recovery, and diagnostic text that must not establish logout. All 191 local tests and
git diff --checkpass; the new regressions failed against the previous implementation. Focused local review found no additional actionable issues.The recording shows refresh followed by an error indicator; its exact underlying CLI error could not be captured because live UI inspection timed out. A read-only CLI check reported logged in. This fixes the confirmed classification defect without claiming the recorded incident was fully reproduced live.