Align JudgmentKit’s header with Surfaces - #60
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07dbf6e8e3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .surfaces-navigation-sections a[aria-current="page"] { | ||
| font-weight: 800; | ||
| text-decoration: underline; | ||
| text-underline-offset: 5px; |
There was a problem hiding this comment.
Restore a visible current state for the home link
When pathName is /, the renderer assigns aria-current="page" only to the brand identifier, but this changed rule applies the visible underline solely to links inside .surfaces-navigation-sections; consequently, the home link looks identical on the homepage and every other page. This violates the visible current-page-state contract in specs/site-header.md; include the identifier in a width-stable active-state rule and cover its rendered style in the browser test.
AGENTS.md reference: AGENTS.md:L12-L12
Useful? React with 👍 / 👎.
Replace JudgmentKit’s ecosystem dropdown with a direct surfaces.systems link and align the shared header layout with Surfaces. JudgmentKit keeps its own favicon logomark and all six navigation destinations.
The header now shares Surfaces’ 72 px height, gutters, Inter typography, mark placement, and link baseline. The mobile menu retains keyboard operation and dismiss behavior; active links keep their width, and the header remains aligned while scrolling and returning through browser history. Classic scrollbar space is reserved so shorter pages keep the same alignment.
Validation:
100%versus the equivalent100% auto; the updated assertion retains both required layer dimensions and passes desktop/mobile pattern checks.