Skip to content

Align JudgmentKit’s header with Surfaces - #60

Merged
mikeylong merged 3 commits into
mainfrom
codex/judgmentkit-header
Oct 2, 2026
Merged

mikeylong merged 3 commits into
mainfrom
codex/judgmentkit-header

Conversation

@mikeylong

@mikeylong mikeylong commented Oct 2, 2026 •

Copy link
Copy Markdown
Owner

Replace JudgmentKit’s ecosystem dropdown with a direct surfaces.systems link and align the shared header layout with Surfaces. JudgmentKit keeps its own favicon logomark and all six navigation destinations.

The header now shares Surfaces’ 72 px height, gutters, Inter typography, mark placement, and link baseline. The mobile menu retains keyboard operation and dismiss behavior; active links keep their width, and the header remains aligned while scrolling and returning through browser history. Classic scrollbar space is reserved so shorter pages keep the same alignment.

Validation:

  • Site build and static site checks passed on the isolated branch.
  • All 14 header browser cases passed across seven widths in light and dark modes, including favicon loading, menu operation, sticky positioning, navigation alignment, and Back restoration.
  • Desktop and mobile comparison with live Surfaces matched the header, shell, mark slot, wordmark baseline, and mobile Menu placement.
  • The marketing-pattern assertion now compares background dimensions instead of Chrome’s CSS serialization. The existing main assertion failed locally and in CI on 100% versus the equivalent 100% auto; the updated assertion retains both required layer dimensions and passes desktop/mobile pattern checks.

@vercel

vercel Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
judgmentkit-ai Ready Ready Preview Oct 2, 2026 1:28am UTC

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T01:10:18.476236Z 07dbf6e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 07dbf6e8e3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread site/build-site.mjs
Comment on lines 1251 to +1253
.surfaces-navigation-sections a[aria-current="page"] {
font-weight: 800;
text-decoration: underline;
text-underline-offset: 5px;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore a visible current state for the home link

When pathName is /, the renderer assigns aria-current="page" only to the brand identifier, but this changed rule applies the visible underline solely to links inside .surfaces-navigation-sections; consequently, the home link looks identical on the homepage and every other page. This violates the visible current-page-state contract in specs/site-header.md; include the identifier in a width-stable active-state rule and cover its rendered style in the browser test.

AGENTS.md reference: AGENTS.md:L12-L12

Useful? React with 👍 / 👎.

@mikeylong
mikeylong merged commit 4cbbed6 into main Oct 2, 2026
5 checks passed

This branch was successfully deployed

1 active deployment
Preview — ee904e84 Deployed Oct 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant