Skip to content

[code-audit] FalaArtifactStore importuje fala.artifacts, którego nie ma w Fala v0.7.28 ani v0.8.1; extra pinuje martwy tag - #110

Open
mikolaj92 wants to merge 4 commits into
mainfrom
lokay/96
Open

mikolaj92 wants to merge 4 commits into
mainfrom
lokay/96

Conversation

@mikolaj92

@mikolaj92 mikolaj92 commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

Issue #96

Cel

  • Usunąć zależność od nieistniejącego API artefaktów bez regresji backendu wykonania, bezpieczeństwa routera ani stanu workerów.
  • Najpierw sprawdzić stan docelowego worktree i jego diff. Ten checkout main nadal zawiera adapter i pin v0.7.28.
  • Wyniki poprzednich prób traktować jako dowody historyczne, nie potwierdzenie aktualnego stanu ani zielonych kontroli.
  • Zgłoszenie traktować wyłącznie jako dowód. Wyszukiwać tylko wewnątrz katalogu roboczego; nie czytać innych planów.
  • Usunąć FalaArtifactStore zamiast tworzyć zamiennik. Zachować ogólny protokół ArtifactStore i leniwe importowanie opcjonalnych zależności.
  • Zachować przekazanie callbacku, identyfikatorów, wejść i metadanych oraz niezmienione wyniki i wyjątki FalaExecutionBackend.
  • Nie zmieniać odpowiedzialności za tworzenie runów, checkpointy, retry, journal ani procesy workerów.
  • Wyeliminować źródło Git Fali zarówno z metadanych, jak i lockfile. Sam tag v0.8.1 nadal uruchamiał zablokowany git fetch.
  • Użyć archiwum HTTPS przypiętego do commita 27c179aee96daf6953ef36d6b1a007214d14a0db, po potwierdzeniu budowania i publicznego API.
  • Nie obchodzić ograniczeń sandboxa. Niedostępność archiwum zgłosić jako blokadę, bez powtarzania zablokowanego pobierania Git.
  • Rozwiązać konflikt dokumentacji FastAPI przez usunięcie docstringa modułu i zachowanie potrzebnego opisu w README, bez odtwarzania docstringa.
  • Nie dodawać komentarzy kodu, docstringów ani nowych testów jednostkowych.
  • Każdy dotykany dokument przeczytać w całości przed zmianą. Usunąć treści nieaktualne i powtórzenia; dodane linie dokumentacji nie przekraczają usuniętych.
  • Dokumentacja opisuje wyłącznie działanie projektu, bez historii zgłoszenia, uzasadnień procesu ani relacji z kontroli.

Zmienione pliki

README.md                                  |  24 +++---
 pyproject.toml                             |   9 +-
 src/datasource_kit/adapters/fala.py        |  61 +-------------
 src/datasource_kit/adapters/fastapi.py     |  16 ----
 tests/adapters/test_fala_artifact_store.py | 129 -----------------------------
 tests/adapters/test_fala_extra_source.py   |  16 ++--
 uv.lock                                    |  11 ++-
 7 files changed, 32 insertions(+), 234 deletions(-)

Checks

SHA: 9996f1aae9545dfca659c00869734fb40aff7dd0

name status reason
ci_green pass GitHub CI green at 9996f1a; expected green or no_ci at 9996f1a
local_tests pass 316 passed
merge_clean pass merge is clean
lockfile pass uv lock checks passed
secrets pass no secrets found
junk pass no generated junk files
no_new_comments fail tests/adapters/test_fala_extra_source.py: new unit test -> add a replay fixture under fixtures/replay and run uv run lokay replay
no_unit_tests fail new unit tests: tests/adapters/test_fala_extra_source.py
docs pass no documentation expansion
plan_target pass diff touches planned files

Uwagi bez konkretu

  • alignment: src/datasource_kit/adapters/fastapi.py:1-3:
    Dispute: alignment src/datasource_kit/adapters/fastapi.py:1-3: Przywrócenie pozostałej dokumentacji modułu wymaga zapisania docstringa. To narusza zakaz „no docstrings”.

scope src/datasource_kit/adapters/fastapi.py:1-3: Ta sama sprzeczność uniemożliwia poprawkę. Przywrócenie docstringa wymaga wyjątku od twardej reguły.

Closes #96

Opened by lokay.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@mikolaj92

Copy link
Copy Markdown
Owner Author

Lokay Check 1

SHA: b59d8511ad2d20dda7ff2aa7aef1eec4b77bf166

Wynik: pending · CI: pending · tests: pending · tested=false

Uwagi i CI:

{
  "uwagi": [],
  "notes": [],
  "failed": [],
  "pending": [
    "test (3.12)",
    "test (3.13)"
  ]
}

@mikolaj92

Copy link
Copy Markdown
Owner Author

Lokay Check 1

SHA: b59d8511ad2d20dda7ff2aa7aef1eec4b77bf166

Wynik: wait · CI: green · tests: red · tested=false

name status reason
ci_green pass GitHub CI green at b59d851; expected green or no_ci at b59d851
local_tests fail local tests not green or not run: setup: -96 Updating https://github.com/mikolaj92/Fala (v0.8.1) × Failed to download and build fala @ │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db ├─▶ Git operation failed ├─▶ failed to fetch into: │ /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9 ├─▶ failed to fetch commit 27c179aee96daf6953ef36d6b1a007214d14a0db ╰─▶ process didn't exit successfully: /Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force --update-head-ok 'https://github.com/mikolaj92/Fala' '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db' (exit status: 1) --- stderr git: command blocked for pi hint: fala was included because datasource-kit[fala] (v0.15.0) depends on fala
merge_clean pass stub
plan_files pass stub
lockfile pass stub
secrets pass stub
permissions pass stub
no_new_comments pass no new comments or lint errors
no_unit_tests pass no new unit tests
issue_goal pass stub
scope pass stub
correctness pass stub
tests_cover pass stub
regression pass stub
architecture pass stub
security_review pass stub
docs pass no documentation expansion
style pass stub

Uwagi i CI:

{
  "uwagi": [],
  "notes": [
    {
      "warstwa": "setup",
      "plik": "",
      "log": "Setup: .: ['uv', 'sync', '--frozen', '--all-extras']\nexit=1\nUsing CPython 3.14.3\nCreating virtual environment at: .venv\n   Building datasource-kit @ file:///Users/mini-m4-0/Developer/datasource-kit/main-wt-96\n   Updating https://github.com/mikolaj92/Fala (v0.8.1)\n  × Failed to download and build `fala @\n  │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ├─▶ Git operation failed\n  ├─▶ failed to fetch into:\n  │   /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9\n  ├─▶ failed to fetch commit `27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ╰─▶ process didn't exit successfully:\n      `/Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force\n      --update-head-ok 'https://github.com/mikolaj92/Fala'\n      '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db'`\n      (exit status: 1)\n      --- stderr\n      git: command blocked for pi\n\n\nhint: `fala` was included because `datasource-kit[fala]` (v0.15.0) depends on `fala`"
    },
    {
      "warstwa": "local_tests",
      "log": "local tests not green or not run: setup: -96\n   Updating https://github.com/mikolaj92/Fala (v0.8.1)\n  × Failed to download and build `fala @\n  │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ├─▶ Git operation failed\n  ├─▶ failed to fetch into:\n  │   /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9\n  ├─▶ failed to fetch commit `27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ╰─▶ process didn't exit successfully:\n      `/Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force\n      --update-head-ok 'https://github.com/mikolaj92/Fala'\n      '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db'`\n      (exit status: 1)\n      --- stderr\n      git: command blocked for pi\n\n\nhint: `fala` was included because `datasource-kit[fala]` (v0.15.0) depends on `fala`",
      "status": "fail"
    }
  ],
  "failed": [
    {
      "warstwa": "setup",
      "plik": "",
      "log": "Setup: .: ['uv', 'sync', '--frozen', '--all-extras']\nexit=1\nUsing CPython 3.14.3\nCreating virtual environment at: .venv\n   Building datasource-kit @ file:///Users/mini-m4-0/Developer/datasource-kit/main-wt-96\n   Updating https://github.com/mikolaj92/Fala (v0.8.1)\n  × Failed to download and build `fala @\n  │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ├─▶ Git operation failed\n  ├─▶ failed to fetch into:\n  │   /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9\n  ├─▶ failed to fetch commit `27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ╰─▶ process didn't exit successfully:\n      `/Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force\n      --update-head-ok 'https://github.com/mikolaj92/Fala'\n      '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db'`\n      (exit status: 1)\n      --- stderr\n      git: command blocked for pi\n\n\nhint: `fala` was included because `datasource-kit[fala]` (v0.15.0) depends on `fala`"
    }
  ],
  "pending": []
}

@mikolaj92

Copy link
Copy Markdown
Owner Author

Lokay Check 2

SHA: b59d8511ad2d20dda7ff2aa7aef1eec4b77bf166

Wynik: wait · CI: green · tests: red · tested=false

name status reason
ci_green pass GitHub CI green at b59d851; expected green or no_ci at b59d851
local_tests fail local tests not green or not run: setup: -96 Updating https://github.com/mikolaj92/Fala (v0.8.1) × Failed to download and build fala @ │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db ├─▶ Git operation failed ├─▶ failed to fetch into: │ /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9 ├─▶ failed to fetch commit 27c179aee96daf6953ef36d6b1a007214d14a0db ╰─▶ process didn't exit successfully: /Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force --update-head-ok 'https://github.com/mikolaj92/Fala' '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db' (exit status: 1) --- stderr git: command blocked for pi hint: fala was included because datasource-kit[fala] (v0.15.0) depends on fala
merge_clean pass stub
plan_files pass stub
lockfile pass stub
secrets pass stub
permissions pass stub
no_new_comments pass no new comments or lint errors
no_unit_tests pass no new unit tests
issue_goal pass stub
scope pass stub
correctness pass stub
tests_cover pass stub
regression pass stub
architecture pass stub
security_review pass stub
docs pass no documentation expansion
style pass stub

Uwagi i CI:

{
  "uwagi": [],
  "notes": [
    {
      "warstwa": "setup",
      "plik": "",
      "log": "Setup: .: ['uv', 'sync', '--frozen', '--all-extras']\nexit=1\nUsing CPython 3.14.3\nCreating virtual environment at: .venv\n   Building datasource-kit @ file:///Users/mini-m4-0/Developer/datasource-kit/main-wt-96\n   Updating https://github.com/mikolaj92/Fala (v0.8.1)\n  × Failed to download and build `fala @\n  │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ├─▶ Git operation failed\n  ├─▶ failed to fetch into:\n  │   /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9\n  ├─▶ failed to fetch commit `27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ╰─▶ process didn't exit successfully:\n      `/Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force\n      --update-head-ok 'https://github.com/mikolaj92/Fala'\n      '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db'`\n      (exit status: 1)\n      --- stderr\n      git: command blocked for pi\n\n\nhint: `fala` was included because `datasource-kit[fala]` (v0.15.0) depends on `fala`"
    },
    {
      "warstwa": "local_tests",
      "log": "local tests not green or not run: setup: -96\n   Updating https://github.com/mikolaj92/Fala (v0.8.1)\n  × Failed to download and build `fala @\n  │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ├─▶ Git operation failed\n  ├─▶ failed to fetch into:\n  │   /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9\n  ├─▶ failed to fetch commit `27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ╰─▶ process didn't exit successfully:\n      `/Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force\n      --update-head-ok 'https://github.com/mikolaj92/Fala'\n      '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db'`\n      (exit status: 1)\n      --- stderr\n      git: command blocked for pi\n\n\nhint: `fala` was included because `datasource-kit[fala]` (v0.15.0) depends on `fala`",
      "status": "fail"
    }
  ],
  "failed": [
    {
      "warstwa": "setup",
      "plik": "",
      "log": "Setup: .: ['uv', 'sync', '--frozen', '--all-extras']\nexit=1\nUsing CPython 3.14.3\nCreating virtual environment at: .venv\n   Building datasource-kit @ file:///Users/mini-m4-0/Developer/datasource-kit/main-wt-96\n   Updating https://github.com/mikolaj92/Fala (v0.8.1)\n  × Failed to download and build `fala @\n  │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ├─▶ Git operation failed\n  ├─▶ failed to fetch into:\n  │   /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9\n  ├─▶ failed to fetch commit `27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ╰─▶ process didn't exit successfully:\n      `/Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force\n      --update-head-ok 'https://github.com/mikolaj92/Fala'\n      '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db'`\n      (exit status: 1)\n      --- stderr\n      git: command blocked for pi\n\n\nhint: `fala` was included because `datasource-kit[fala]` (v0.15.0) depends on `fala`"
    }
  ],
  "pending": []
}

@mikolaj92

Copy link
Copy Markdown
Owner Author

Lokay Check 3

SHA: b59d8511ad2d20dda7ff2aa7aef1eec4b77bf166

Wynik: wait · CI: green · tests: red · tested=false

name status reason
ci_green pass GitHub CI green at b59d851; expected green or no_ci at b59d851
local_tests fail local tests not green or not run: setup: -96 Updating https://github.com/mikolaj92/Fala (v0.8.1) × Failed to download and build fala @ │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db ├─▶ Git operation failed ├─▶ failed to fetch into: │ /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9 ├─▶ failed to fetch commit 27c179aee96daf6953ef36d6b1a007214d14a0db ╰─▶ process didn't exit successfully: /Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force --update-head-ok 'https://github.com/mikolaj92/Fala' '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db' (exit status: 1) --- stderr git: command blocked for pi hint: fala was included because datasource-kit[fala] (v0.15.0) depends on fala
merge_clean pass stub
plan_files pass stub
lockfile pass stub
secrets pass stub
permissions pass stub
no_new_comments pass no new comments or lint errors
no_unit_tests pass no new unit tests
issue_goal pass stub
scope pass stub
correctness pass stub
tests_cover pass stub
regression pass stub
architecture pass stub
security_review pass stub
docs pass no documentation expansion
style pass stub

Uwagi i CI:

{
  "uwagi": [],
  "notes": [
    {
      "warstwa": "setup",
      "plik": "",
      "log": "Setup: .: ['uv', 'sync', '--frozen', '--all-extras']\nexit=1\nUsing CPython 3.14.3\nCreating virtual environment at: .venv\n   Building datasource-kit @ file:///Users/mini-m4-0/Developer/datasource-kit/main-wt-96\n   Updating https://github.com/mikolaj92/Fala (v0.8.1)\n  × Failed to download and build `fala @\n  │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ├─▶ Git operation failed\n  ├─▶ failed to fetch into:\n  │   /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9\n  ├─▶ failed to fetch commit `27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ╰─▶ process didn't exit successfully:\n      `/Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force\n      --update-head-ok 'https://github.com/mikolaj92/Fala'\n      '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db'`\n      (exit status: 1)\n      --- stderr\n      git: command blocked for pi\n\n\nhint: `fala` was included because `datasource-kit[fala]` (v0.15.0) depends on `fala`"
    },
    {
      "warstwa": "local_tests",
      "log": "local tests not green or not run: setup: -96\n   Updating https://github.com/mikolaj92/Fala (v0.8.1)\n  × Failed to download and build `fala @\n  │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ├─▶ Git operation failed\n  ├─▶ failed to fetch into:\n  │   /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9\n  ├─▶ failed to fetch commit `27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ╰─▶ process didn't exit successfully:\n      `/Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force\n      --update-head-ok 'https://github.com/mikolaj92/Fala'\n      '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db'`\n      (exit status: 1)\n      --- stderr\n      git: command blocked for pi\n\n\nhint: `fala` was included because `datasource-kit[fala]` (v0.15.0) depends on `fala`",
      "status": "fail"
    }
  ],
  "failed": [
    {
      "warstwa": "setup",
      "plik": "",
      "log": "Setup: .: ['uv', 'sync', '--frozen', '--all-extras']\nexit=1\nUsing CPython 3.14.3\nCreating virtual environment at: .venv\n   Building datasource-kit @ file:///Users/mini-m4-0/Developer/datasource-kit/main-wt-96\n   Updating https://github.com/mikolaj92/Fala (v0.8.1)\n  × Failed to download and build `fala @\n  │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ├─▶ Git operation failed\n  ├─▶ failed to fetch into:\n  │   /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9\n  ├─▶ failed to fetch commit `27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ╰─▶ process didn't exit successfully:\n      `/Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force\n      --update-head-ok 'https://github.com/mikolaj92/Fala'\n      '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db'`\n      (exit status: 1)\n      --- stderr\n      git: command blocked for pi\n\n\nhint: `fala` was included because `datasource-kit[fala]` (v0.15.0) depends on `fala`"
    }
  ],
  "pending": []
}

@mikolaj92

Copy link
Copy Markdown
Owner Author

Lokay Check 4

SHA: b59d8511ad2d20dda7ff2aa7aef1eec4b77bf166

Wynik: wait · CI: green · tests: red · tested=false

name status reason
ci_green pass GitHub CI green at b59d851; expected green or no_ci at b59d851
local_tests fail local tests not green or not run: setup: -96 Updating https://github.com/mikolaj92/Fala (v0.8.1) × Failed to download and build fala @ │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db ├─▶ Git operation failed ├─▶ failed to fetch into: │ /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9 ├─▶ failed to fetch commit 27c179aee96daf6953ef36d6b1a007214d14a0db ╰─▶ process didn't exit successfully: /Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force --update-head-ok 'https://github.com/mikolaj92/Fala' '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db' (exit status: 1) --- stderr git: command blocked for pi hint: fala was included because datasource-kit[fala] (v0.15.0) depends on fala
merge_clean pass stub
plan_files pass stub
lockfile pass stub
secrets pass stub
permissions pass stub
no_new_comments pass no new comments or lint errors
no_unit_tests pass no new unit tests
issue_goal pass stub
scope pass stub
correctness pass stub
tests_cover pass stub
regression pass stub
architecture pass stub
security_review pass stub
docs pass no documentation expansion
style pass stub

Uwagi i CI:

{
  "uwagi": [],
  "notes": [
    {
      "warstwa": "setup",
      "plik": "",
      "log": "Setup: .: ['uv', 'sync', '--frozen', '--all-extras']\nexit=1\nUsing CPython 3.14.3\nCreating virtual environment at: .venv\n   Building datasource-kit @ file:///Users/mini-m4-0/Developer/datasource-kit/main-wt-96\n   Updating https://github.com/mikolaj92/Fala (v0.8.1)\n  × Failed to download and build `fala @\n  │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ├─▶ Git operation failed\n  ├─▶ failed to fetch into:\n  │   /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9\n  ├─▶ failed to fetch commit `27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ╰─▶ process didn't exit successfully:\n      `/Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force\n      --update-head-ok 'https://github.com/mikolaj92/Fala'\n      '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db'`\n      (exit status: 1)\n      --- stderr\n      git: command blocked for pi\n\n\nhint: `fala` was included because `datasource-kit[fala]` (v0.15.0) depends on `fala`"
    },
    {
      "warstwa": "local_tests",
      "log": "local tests not green or not run: setup: -96\n   Updating https://github.com/mikolaj92/Fala (v0.8.1)\n  × Failed to download and build `fala @\n  │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ├─▶ Git operation failed\n  ├─▶ failed to fetch into:\n  │   /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9\n  ├─▶ failed to fetch commit `27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ╰─▶ process didn't exit successfully:\n      `/Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force\n      --update-head-ok 'https://github.com/mikolaj92/Fala'\n      '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db'`\n      (exit status: 1)\n      --- stderr\n      git: command blocked for pi\n\n\nhint: `fala` was included because `datasource-kit[fala]` (v0.15.0) depends on `fala`",
      "status": "fail"
    }
  ],
  "failed": [
    {
      "warstwa": "setup",
      "plik": "",
      "log": "Setup: .: ['uv', 'sync', '--frozen', '--all-extras']\nexit=1\nUsing CPython 3.14.3\nCreating virtual environment at: .venv\n   Building datasource-kit @ file:///Users/mini-m4-0/Developer/datasource-kit/main-wt-96\n   Updating https://github.com/mikolaj92/Fala (v0.8.1)\n  × Failed to download and build `fala @\n  │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ├─▶ Git operation failed\n  ├─▶ failed to fetch into:\n  │   /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9\n  ├─▶ failed to fetch commit `27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ╰─▶ process didn't exit successfully:\n      `/Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force\n      --update-head-ok 'https://github.com/mikolaj92/Fala'\n      '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db'`\n      (exit status: 1)\n      --- stderr\n      git: command blocked for pi\n\n\nhint: `fala` was included because `datasource-kit[fala]` (v0.15.0) depends on `fala`"
    }
  ],
  "pending": []
}

@mikolaj92

Copy link
Copy Markdown
Owner Author

Lokay Check 5

SHA: b59d8511ad2d20dda7ff2aa7aef1eec4b77bf166

Wynik: wait · CI: green · tests: red · tested=false

name status reason
ci_green pass GitHub CI green at b59d851; expected green or no_ci at b59d851
local_tests fail local tests not green or not run: setup: -96 Updating https://github.com/mikolaj92/Fala (v0.8.1) × Failed to download and build fala @ │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db ├─▶ Git operation failed ├─▶ failed to fetch into: │ /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9 ├─▶ failed to fetch commit 27c179aee96daf6953ef36d6b1a007214d14a0db ╰─▶ process didn't exit successfully: /Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force --update-head-ok 'https://github.com/mikolaj92/Fala' '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db' (exit status: 1) --- stderr git: command blocked for pi hint: fala was included because datasource-kit[fala] (v0.15.0) depends on fala
merge_clean pass stub
plan_files pass stub
lockfile pass stub
secrets pass stub
permissions pass stub
no_new_comments pass no new comments or lint errors
no_unit_tests pass no new unit tests
issue_goal pass stub
scope pass stub
correctness pass stub
tests_cover pass stub
regression pass stub
architecture pass stub
security_review pass stub
docs pass no documentation expansion
style pass stub

Uwagi i CI:

{
  "uwagi": [],
  "notes": [
    {
      "warstwa": "setup",
      "plik": "",
      "log": "Setup: .: ['uv', 'sync', '--frozen', '--all-extras']\nexit=1\nUsing CPython 3.14.3\nCreating virtual environment at: .venv\n   Building datasource-kit @ file:///Users/mini-m4-0/Developer/datasource-kit/main-wt-96\n   Updating https://github.com/mikolaj92/Fala (v0.8.1)\n  × Failed to download and build `fala @\n  │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ├─▶ Git operation failed\n  ├─▶ failed to fetch into:\n  │   /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9\n  ├─▶ failed to fetch commit `27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ╰─▶ process didn't exit successfully:\n      `/Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force\n      --update-head-ok 'https://github.com/mikolaj92/Fala'\n      '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db'`\n      (exit status: 1)\n      --- stderr\n      git: command blocked for pi\n\n\nhint: `fala` was included because `datasource-kit[fala]` (v0.15.0) depends on `fala`"
    },
    {
      "warstwa": "local_tests",
      "log": "local tests not green or not run: setup: -96\n   Updating https://github.com/mikolaj92/Fala (v0.8.1)\n  × Failed to download and build `fala @\n  │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ├─▶ Git operation failed\n  ├─▶ failed to fetch into:\n  │   /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9\n  ├─▶ failed to fetch commit `27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ╰─▶ process didn't exit successfully:\n      `/Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force\n      --update-head-ok 'https://github.com/mikolaj92/Fala'\n      '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db'`\n      (exit status: 1)\n      --- stderr\n      git: command blocked for pi\n\n\nhint: `fala` was included because `datasource-kit[fala]` (v0.15.0) depends on `fala`",
      "status": "fail"
    }
  ],
  "failed": [
    {
      "warstwa": "setup",
      "plik": "",
      "log": "Setup: .: ['uv', 'sync', '--frozen', '--all-extras']\nexit=1\nUsing CPython 3.14.3\nCreating virtual environment at: .venv\n   Building datasource-kit @ file:///Users/mini-m4-0/Developer/datasource-kit/main-wt-96\n   Updating https://github.com/mikolaj92/Fala (v0.8.1)\n  × Failed to download and build `fala @\n  │ git+https://github.com/mikolaj92/Fala@27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ├─▶ Git operation failed\n  ├─▶ failed to fetch into:\n  │   /Users/mini-m4-0/.cache/uv/git-v0/db/92b8d2c80dfe32d9\n  ├─▶ failed to fetch commit `27c179aee96daf6953ef36d6b1a007214d14a0db`\n  ╰─▶ process didn't exit successfully:\n      `/Users/mini-m4-0/.lokay/host/sandbox/bin/git fetch --force\n      --update-head-ok 'https://github.com/mikolaj92/Fala'\n      '+27c179aee96daf6953ef36d6b1a007214d14a0db:refs/commit/27c179aee96daf6953ef36d6b1a007214d14a0db'`\n      (exit status: 1)\n      --- stderr\n      git: command blocked for pi\n\n\nhint: `fala` was included because `datasource-kit[fala]` (v0.15.0) depends on `fala`"
    }
  ],
  "pending": []
}

@mikolaj92

Copy link
Copy Markdown
Owner Author

Lokay Check 6

SHA: 101d97613d8ff3839b8a2bc80d4ffd2e15cd1703

Wynik: pending · CI: pending · tests: pending · tested=false

Uwagi i CI:

{
  "uwagi": [],
  "notes": [],
  "failed": [],
  "pending": [
    "test (3.12)",
    "test (3.13)"
  ]
}

@mikolaj92

Copy link
Copy Markdown
Owner Author

Lokay Check 6

SHA: 101d97613d8ff3839b8a2bc80d4ffd2e15cd1703

Wynik: fix · CI: green · tests: green · tested=true

name status reason
ci_green pass GitHub CI green at 101d976; expected green or no_ci at 101d976
local_tests pass local tests green
merge_clean pass stub
plan_files pass stub
lockfile pass stub
secrets pass stub
permissions pass stub
no_new_comments pass no new comments or lint errors
no_unit_tests pass no new unit tests
issue_goal pass stub
scope pass stub
correctness pass stub
tests_cover pass stub
regression pass stub
architecture pass stub
security_review pass stub
docs pass no documentation expansion
style pass stub

Uwagi i CI:

{
  "uwagi": [
    {
      "plik": "src/datasource_kit/adapters/fastapi.py",
      "linia_od": 1,
      "linia_do": 3,
      "pytanie": "alignment",
      "p": 0.9,
      "uzasadnienie": "The functional changes address the issue, but deleting the entire FastAPI adapter module docstring unnecessarily removes unrelated installation, security, and control-plane documentation. Only its reference to the removed Fala artifact adapter needs updating.\nThe deletion removes the entire FastAPI module docstring, including still-applicable installation instructions, lazy-import behavior, host-owned authentication, and control-plane delegation details. Removing or rewriting the stale Fala artifact-store comparison is relevant, but deleting all the independent FastAPI documentation is unnecessary scope drift."
    },
    {
      "plik": "src/datasource_kit/adapters/fastapi.py",
      "linia_od": 1,
      "linia_do": 3,
      "pytanie": "scope",
      "p": 0.88,
      "uzasadnienie": "The Fala adapter removal, dependency update, tests, and lockfile changes are in scope. However, the FastAPI hunk deletes its entire module documentation, including unrelated installation, authentication, mounting, and control-plane behavior guidance; only its obsolete Fala artifact-store comparison needs removal.\nRemoving the obsolete comparison to the Fala artifact adapter is relevant, but deleting the entire FastAPI module docstring also removes independent documentation about installation, lazy imports, host-provided authentication, router mounting, and control-plane delegation. That broader deletion is not requested or shown to be necessary for CI."
    }
  ],
  "notes": [
    {
      "warstwa": "scope",
      "plik": "",
      "log": "Diff contains files outside ## Pliki: src/datasource_kit/adapters/fastapi.py"
    }
  ],
  "failed": [],
  "pending": []
}

@mikolaj92

Copy link
Copy Markdown
Owner Author

Auto-fixing stopped: run_rounds reached 6.

Uwagi: [{"plik": "src/datasource_kit/adapters/fastapi.py", "linia_od": 1, "linia_do": 3, "pytanie": "alignment", "p": 0.9, "uzasadnienie": "The functional changes address the issue, but deleting the entire FastAPI adapter module docstring unnecessarily removes unrelated installation, security, and control-plane documentation. Only its reference to the removed Fala artifact adapter needs updating.\nThe deletion removes the entire FastAPI module docstring, including still-applicable installation instructions, lazy-import behavior, host-owned authentication, and control-plane delegation details. Removing or rewriting the stale Fala artifact-store comparison is relevant, but deleting all the independent FastAPI documentation is unnecessary scope drift."}, {"plik": "src/datasource_kit/adapters/fastapi.py", "linia_od": 1, "linia_do": 3, "pytanie": "scope", "p": 0.88, "uzasadnienie": "The Fala adapter removal, dependency update, tests, and lockfile changes are in scope. However, the FastAPI hunk deletes its entire module documentation, including unrelated installation, authentication, mounting, and control-plane behavior guidance; only its obsolete Fala artifact-store comparison needs removal.\nRemoving the obsolete comparison to the Fala artifact adapter is relevant, but deleting the entire FastAPI module docstring also removes independent documentation about installation, lazy imports, host-provided authentication, router mounting, and control-plane delegation. That broader deletion is not requested or shown to be necessary for CI."}]

@mikolaj92

Copy link
Copy Markdown
Owner Author

Lokay Check 7

SHA: 101d97613d8ff3839b8a2bc80d4ffd2e15cd1703

Wynik: fix · CI: green · tests: green · tested=true

name status reason
ci_green pass GitHub CI green at 101d976; expected green or no_ci at 101d976
local_tests pass local tests green
merge_clean pass stub
plan_files pass stub
lockfile pass uv lock checks passed
secrets pass stub
junk pass no generated junk files
no_new_comments pass no new comments or lint errors
no_unit_tests pass no new unit tests
issue_goal pass stub
scope pass stub
correctness pass stub
tests_cover pass stub
regression pass stub
architecture pass stub
security_review pass stub
docs pass no documentation expansion
style pass stub

Uwagi i CI:

{
  "uwagi": [
    {
      "plik": "src/datasource_kit/adapters/fastapi.py",
      "linia_od": 1,
      "linia_do": 3,
      "pytanie": "alignment",
      "p": 0.98,
      "uzasadnienie": "The Fala changes address the issue, but deleting the entire FastAPI module docstring unnecessarily removes unrelated installation, security, and control-plane documentation. The earlier finding remains unresolved in the current diff.\nsrc/datasource_kit/adapters/fastapi.py:1-3 deletes the entire module docstring, including installation instructions, host-owned authentication guidance, and control-plane delegation behavior. Only the obsolete comparison to the Fala artifact adapter needs removal or revision; deleting the remaining documentation is unrelated scope drift."
    },
    {
      "plik": "src/datasource_kit/adapters/fastapi.py",
      "linia_od": 1,
      "linia_do": 3,
      "pytanie": "scope",
      "p": 0.99,
      "uzasadnienie": "The FastAPI hunk deletes unrelated installation, authentication, mounting, and control-plane documentation. Removing its obsolete Fala artifact-store reference is in scope, but deleting the entire docstring is not. The earlier finding remains unaddressed in the current diff.\nsrc/datasource_kit/adapters/fastapi.py:1-3 deletes the entire module docstring, including unrelated installation instructions, host-owned security and mounting guidance, and control-plane behavior documentation. Only the obsolete comparison to the Fala artifact-store adapter needs removal or revision; retain the remaining documentation. This is the still-present scope concern from history, not a resolved or rejected finding."
    }
  ],
  "notes": [
    {
      "warstwa": "scope",
      "plik": "",
      "log": "Diff contains files outside ## Pliki: src/datasource_kit/adapters/fastapi.py"
    }
  ],
  "failed": [],
  "pending": []
}

@mikolaj92

Copy link
Copy Markdown
Owner Author

Lokay Check 8

SHA: 5aa0b858e2d02da925a054152c7348d7027759d9

Wynik: fix · CI: green · tests: green · tested=true

name status reason
ci_green pass GitHub CI green at 5aa0b85; expected green or no_ci at 5aa0b85
local_tests pass local tests green
merge_clean pass stub
plan_files pass stub
lockfile pass uv lock checks passed
secrets pass stub
junk pass no generated junk files
no_new_comments fail src/datasource_kit/adapters/fastapi.py:1: docstring -> delete it
no_unit_tests pass no new unit tests
issue_goal pass stub
scope pass stub
correctness pass stub
tests_cover pass stub
regression pass stub
architecture pass stub
security_review pass stub
docs pass no documentation expansion
style pass stub

Uwagi i CI:

{
  "uwagi": [
    {
      "plik": "src/datasource_kit/adapters/fastapi.py",
      "linia_od": 1,
      "linia_do": 1,
      "zmiana": "docstring -> delete it",
      "pytanie": "no_new_comments"
    }
  ],
  "notes": [
    {
      "warstwa": "scope",
      "plik": "",
      "log": "Diff contains files outside ## Pliki: src/datasource_kit/adapters/fastapi.py"
    }
  ],
  "failed": [],
  "pending": []
}

@mikolaj92

Copy link
Copy Markdown
Owner Author

Lokay Check 9

SHA: 9996f1aae9545dfca659c00869734fb40aff7dd0

Wynik: pending · CI: pending · tests: pending · tested=false

Uwagi i CI:

{
  "uwagi": [],
  "notes": [],
  "failed": [],
  "pending": [
    "test (3.12)"
  ]
}

@mikolaj92

Copy link
Copy Markdown
Owner Author

Lokay Check 9

SHA: 9996f1aae9545dfca659c00869734fb40aff7dd0

Wynik: fix · CI: green · tests: green · tested=true

name status reason
ci_green pass GitHub CI green at 9996f1a; expected green or no_ci at 9996f1a
local_tests pass 316 passed
merge_clean pass merge is clean
lockfile pass uv lock checks passed
secrets pass no secrets found
junk pass no generated junk files
no_new_comments fail tests/adapters/test_fala_extra_source.py: new unit test -> add a replay fixture under fixtures/replay and run uv run lokay replay
no_unit_tests fail new unit tests: tests/adapters/test_fala_extra_source.py
docs pass no documentation expansion
plan_target pass diff touches planned files

Uwagi i CI:

{
  "uwagi": [
    {
      "plik": "tests/adapters/test_fala_extra_source.py",
      "linia_od": 1,
      "linia_do": 1,
      "zmiana": "new unit test -> add a replay fixture under fixtures/replay and run uv run lokay replay",
      "pytanie": "no_new_comments"
    },
    {
      "plik": "tests/adapters/test_fala_extra_source.py",
      "linia_od": 8,
      "linia_do": 8,
      "zmiana": "add a replay fixture under fixtures/replay",
      "pytanie": "no_unit_tests"
    }
  ],
  "notes": [],
  "failed": [],
  "pending": []
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[code-audit] FalaArtifactStore importuje fala.artifacts, którego nie ma w Fala v0.7.28 ani v0.8.1; extra pinuje martwy tag

1 participant