Repository navigation
release(0.24.1): Pack-only API cleanup - #366
Merged
Merged
Conversation
Require typed Pack, DecisionClient, and LLMClient on the public review path. Drop the fused pack=None single-pass, pass Pydantic decision states with SourceUnit objects, and load Pack JSON only through model_validate / model_validate_json. Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
State that 0.24 is a generic review process: the same engine reviews a privacy notice or a newspaper article and only Pack content changes. Keep Pack schema abstract (functions, rules, units) and lock core against RODO/Temida product vocabulary. Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
Hosts construct Pack/Ontology/Rule/SourceUnit in Python; JSON is a file-edge load. Public Platforms rows are Host Pack + example Pack, not a product host. Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/pack-only-review-ead4
branch
from
September 29, 2026 18:04
4fd00c7 to
2fea5ec
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking cleanup of the 0.24 public review API. Pack +
DecisionClient+LLMClientis the only path.Cleanup
pack=Nonesingle-pass (complete_jsonof findings+actions, fused reconciliation) fromreview_tree/review_source/review_document/TaktReviewer/ CLI.packanddecisionare required typed instances. There is no optional default.detect/judge/BaseLLMDetectorstay off the package root.Host contract
Hosts construct
Pack/Ontology/Rule/SourceUnitin Python (orPack.model_validate/Pack.model_validate_jsononce at a file edge). JSON is serialization, not the integration API. Decision payloads are frozen Pydantic models with typedSourceUnit | None.Domain
0.24 is a generic review process. The same engine reviews a privacy notice or a newspaper article; only Pack content changes. Pack schema stays abstract (functions, rules, units). Core does not name RODO, a statute, or Temida.
Scientific paper review remains a first-class example Pack on this tree (rebased onto current
main), not a domain insrc/reviewkit.Release
docs/releases/0.24.1.mdrecord the breaking API-surface cleanupHosts that still called the fused path need to pass a Pack and a
DecisionClient. Alfred: Temida experimental should adapt to 0.24.1 typed objects (host work, not this library).