Repository navigation
Conversation
Add a passes=1 default on TaktReviewer.review and the public review entry points. Pass 1 stays today's independent walk. Further passes re-judge with comments and labels already produced on the unit and the smaller units it contains, without dropping earlier discoveries. Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
The public contract is pick a unit size, run it, and call that same level again with prior comments and labels, or move to the next level when the caller says so. Default with no prior and no level stays today's single walk. Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
Review is always recursive. The caller does not pass a count, a level, or a move. prior remains. ReviewState.courses records each visit as a frozen settle/repeat/further row. Document grain is on every run. Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
mikolaj92
left a comment
There was a problem hiding this comment.
Alfred (Grok Bot) — review COMMENT
Co robi: Zamiast level/passes — rekurencyjne courses (settle/repeat/further) + prior na review_tree / Takt. Pack path.
Zgodność z regułami Temida: courses mają żyć w ReviewKit, nie być emulowane w Temidzie (#6840 / #6862). Ten PR jest właściwym miejscem na courses.
Ryzyka:
- Draft + CONFLICTING.
- Relacja do walk-DOCX (#371/#372): courses na Pack tree ≠ walk
review_docx. Nie mieszaj kontraktów w jednym pinie Temidy. - Breaking:
level=/passes=→ TypeError — OK, ale bump major/changelog i pin Temida równolegle.
Blocker: konflikty; nie pinuj w Temida zanim API courses jest stabilne. Nie merge w tej turze.
|
The prior/courses implementation belongs to the retired Pack/Takt review tree. Merged #373 removed that path and the current repository contract has one same-file DOCX walk. Temida #6840 is closed with no production change remaining to port; #7057 tracks removal of old Pack consumers and identifies these drafts as superseded. Closing this draft without merging or reviving the retired review surface. Branch preserved. Disposition is based on independent exact-head source review against main |
Replace the previous
level/passescontract. Review is always recursive, per fragment, with no count. The caller does not pass a number, a level, or a move.Public contract
prior. Removelevelandpassesfromreview_tree,review_source,review_document, andTaktReviewer.review.passes=andlevel=areTypeError.ReviewState.coursesappends one frozen row after each visit:node_id,grain(ReviewScope),move(settle,repeat,further). Comments stay onReviewAction. Labels stay onFunctionTag. The engine writes the move.(node_id, grain); repeat when new information came from a differentnode_id(own new comment does not reopen); further when this visit produced something the containing grain has not consumed. On the document, further hands discoveries to the caller.ReviewScope.DOCUMENTis on every run. An empty queue ends review. No depth cap.ReviewResultand can append a course. It is the same review, not a non-recursive mode.to_report_dictstill dropsstate.Proof (real
review_tree/TaktReviewer.reviewcall)ReviewResultwithstate.courses.passes=andlevel=raiseTypeError.ReviewStatehascourses.