Skip to content

Recursive per-fragment review with courses - #370

Closed
mikolaj92 wants to merge 3 commits into
mainfrom
cursor/opt-in-review-passes-730c
Closed

mikolaj92 wants to merge 3 commits into
mainfrom
cursor/opt-in-review-passes-730c

Conversation

@mikolaj92

@mikolaj92 mikolaj92 commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

Replace the previous level / passes contract. Review is always recursive, per fragment, with no count. The caller does not pass a number, a level, or a move.

Public contract

  • Keep prior. Remove level and passes from review_tree, review_source, review_document, and TaktReviewer.review. passes= and level= are TypeError.
  • ReviewState.courses appends one frozen row after each visit: node_id, grain (ReviewScope), move (settle, repeat, further). Comments stay on ReviewAction. Labels stay on FunctionTag. The engine writes the move.
  • Same rule at every grain, including document: settle when this visit added nothing new or the input set already had a visit for that (node_id, grain); repeat when new information came from a different node_id (own new comment does not reopen); further when this visit produced something the containing grain has not consumed. On the document, further hands discoveries to the caller.
  • Both returns are one run. A fragment repeat does not cancel the document visit. ReviewScope.DOCUMENT is on every run. An empty queue ends review. No depth cap.
  • A call with nothing extra still returns today's ReviewResult and can append a course. It is the same review, not a non-recursive mode. to_report_dict still drops state.

Proof (real review_tree / TaktReviewer.review call)

  • No extra arguments → ReviewResult with state.courses.
  • Empty delta → settle, that fragment is not judged again.
  • A fragment named by a new document visit is judged again.
  • The document row is one of the three moves.
  • passes= and level= raise TypeError.
  • ReviewState has courses.
Open in Web Open in Cursor 

cursoragent and others added 2 commits October 3, 2026 14:08
Add a passes=1 default on TaktReviewer.review and the public review
entry points. Pass 1 stays today's independent walk. Further passes
re-judge with comments and labels already produced on the unit and
the smaller units it contains, without dropping earlier discoveries.

Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
The public contract is pick a unit size, run it, and call that same
level again with prior comments and labels, or move to the next level
when the caller says so. Default with no prior and no level stays
today's single walk.

Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
@cursor cursor Bot changed the title Opt-in extra review passes feed comments and labels Re-enter review per level with prior discoveries Oct 3, 2026
Review is always recursive. The caller does not pass a count, a level,
or a move. prior remains. ReviewState.courses records each visit as a
frozen settle/repeat/further row. Document grain is on every run.

Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
@cursor cursor Bot changed the title Re-enter review per level with prior discoveries Recursive per-fragment review with courses Oct 3, 2026

@mikolaj92 mikolaj92 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alfred (Grok Bot) — review COMMENT

Co robi: Zamiast level/passes — rekurencyjne courses (settle/repeat/further) + prior na review_tree / Takt. Pack path.

Zgodność z regułami Temida: courses mają żyć w ReviewKit, nie być emulowane w Temidzie (#6840 / #6862). Ten PR jest właściwym miejscem na courses.

Ryzyka:

  1. Draft + CONFLICTING.
  2. Relacja do walk-DOCX (#371/#372): courses na Pack tree ≠ walk review_docx. Nie mieszaj kontraktów w jednym pinie Temidy.
  3. Breaking: level=/passes= → TypeError — OK, ale bump major/changelog i pin Temida równolegle.

Blocker: konflikty; nie pinuj w Temida zanim API courses jest stabilne. Nie merge w tej turze.

@PSyron

PSyron commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

The prior/courses implementation belongs to the retired Pack/Takt review tree. Merged #373 removed that path and the current repository contract has one same-file DOCX walk. Temida #6840 is closed with no production change remaining to port; #7057 tracks removal of old Pack consumers and identifies these drafts as superseded. Closing this draft without merging or reviving the retired review surface. Branch preserved.

Disposition is based on independent exact-head source review against main fc1e5340a69e122e51720a36cd8b0764a06e904c; no local tests, application imports or runtime scenarios were run.

@PSyron PSyron closed this Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants