Repository navigation
Draft: improve theme customization (upstream #295) - #4
Conversation
Implementation and validation reportValidated PR head
Local validation
The two local baseline failures are KDE Plasma WaylandPassed in the native QtWebEngine window against an isolated local server and disposable profile. Tested keyboard focus and Escape, the language selector, invalid hex, black-on-black rejection, reset/cancel/apply, exact white and black, mode switching, legacy migration, and corrupt-state fallback. Preset, Generated Material 3, Manual exact, and AMOLED each survived a fresh native process with browser storage cleared. With the UI bundle blocked, the AMOLED boot cover rendered black and white before React. The saved embed color matched each selected theme, and a public embed HTML fixture emitted the displayed generated accent. Remaining validationGTK/WebKit and an actual Discord client unfurl are unverified. GitHub had not reported checks for this head when this comment was posted. PR checks |
milan483
left a comment
There was a problem hiding this comment.
Independent review findings
This review records one required P2 correction and one non-blocking P3 UX suggestion.
I rechecked the current head a3a3d36354a2e5f3e667a110bf1e14ed1f3b15c4, the task specification, and Codex's implementation/validation report. GitHub currently reports no check runs and no commit statuses for this head. The local report records successful typecheck, build, accent parity, i18n, and 14 focused tests; the full Python suite had 930 passed, 2 failed, and 1 skipped, with both failures reported as reproducible on the baseline. GTK/WebKit and an actual Discord client unfurl remain unverified.
Please keep this PR in draft. Address the P2 issue and rerun validation before preparing the upstream contribution.
| contrastRatio(base, bg) < 4.5 || | ||
| contrastRatio(base, ramp.surfaceHighest) < 4.5 || | ||
| contrastRatio(base, ramp.onBase) < 4.5 | ||
| ) return {ramp: null, error: 'exactContrast'}; |
There was a problem hiding this comment.
P3 — Non-blocking validation UX suggestion.
All failed accent contrast checks collapse to exactContrast, so the UI can only show one generic message. Consider returning a structured failure identifying the failing role pair (and optionally its measured ratio), then localize/display the relevant correction. This isn't a merge blocker, but it would make the manual editor easier to troubleshoot.
Implementation and validation reportAddressed the required boot consistency finding in The boot cover and React now share the same preference validation and palette resolver in
Native QtWebEngine on KDE Plasma Wayland passed all four combinations of manual/generated mode and missing/stale cache. Each cover painted the expected palette with the app bundle blocked, then matched the live theme when the bundle was restored. GTK/WebKit remains unverified. The optional contrast-message suggestion remains open. GitHub had yet to report checks for this head at posting time. PR checks |
Follow-up review — head
|
Fork main integration and installationAt the owner's request, merged the tested theme branch into the fork's latest main as The combined source passed typecheck, build, accent verification, localization checks, and diff checks. The Python suite ran 979 tests with 974 passes, 3 skips, and the two previously documented local GSR AV1 / hardware video-decode failures. Installed this exact main build as |
Summary
Planning/handoff PR for upstream Vice #295: improved theme customization, including exact accent/background colors and optional Matugen integration.
Specification:
.ai/tasks/vice-295-theme-customization.mdImplementation scope for this PR
Current status
Base and branch
This branch started from upstream
splitshotz/Vice:main(ad7758bf5) for future upstream PR cleanliness. The fork'smainis three commits ahead with unrelated GUI-close and session-game-tagging changes; they must not be bundled into the upstream contribution.Keep draft until implementation, CI, and review are complete. Do not merge/release without explicit approval.