Fix mixed precision handling for MRHS solver#96
Open
leonhostetler wants to merge 1 commit intodevelopfrom
Open
Fix mixed precision handling for MRHS solver#96leonhostetler wants to merge 1 commit intodevelopfrom
leonhostetler wants to merge 1 commit intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current develop branch in
generic_ks/d_congrad5_fn_quda.c, mixed precision in the non-block solver is set as:However, in the block solver, it is:
For the block solver, this results in sloppy single precision when requesting
MAX_MIXEDinstead of sloppy half precision. I don't know why the precision was set this way for the block solver, but it has a significant negative effect on the performance of MRHS solves because it effectively does not allow the block solver to run with full mixed precision. The performance effect is so bad that it's currently generally better to run without MRHS.This PR fixes it. I note also that the newer branch
feature/quda-exact-currentwhere this file is updated already has this fix. But I am implementing the fix here in thedevelopbranch since this branch/solver is currently used, and we are not yet ready to mergefeature/quda-exact-currentintodevelop.