Respect face remapping in separators#115
Open
mattfidler wants to merge 2 commits intomilkypostman:masterfrom
Open
Respect face remapping in separators#115mattfidler wants to merge 2 commits intomilkypostman:masterfrom
mattfidler wants to merge 2 commits intomilkypostman:masterfrom
Conversation
When adding face remapping, the background of the face is no longer correct. This occurs in the flycheck-color-mode-line package: flycheck/flycheck-color-mode-line#3 This should fix the issue.
Contributor
Author
|
However, the memoize functions don't play nicely when the function changes... |
Contributor
Author
|
This should allow the memoizing to occur while respecting face remapping. |
Owner
|
hey sorry it took me over a year to look at this, unfortunately i've merged other fixes and it won't merge correctly. is there any chance you'd want to update this to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding face remapping, the background of the face is no longer correct.
This occurs in the flycheck-color-mode-line package:
flycheck/flycheck-color-mode-line#3
This should fix the issue.