Skip to content

Added setHashQuiet and replaceHashQuiet methods#65

Open
adamlukaszczyk wants to merge 1 commit intomillermedeiros:masterfrom
adamlukaszczyk:master
Open

Added setHashQuiet and replaceHashQuiet methods#65
adamlukaszczyk wants to merge 1 commit intomillermedeiros:masterfrom
adamlukaszczyk:master

Conversation

@adamlukaszczyk
Copy link

Your documentation state how to set hash without dispatching hash change event:
https://github.com/millermedeiros/Hasher#setting-hash-value-without-dispatching-changed-signal

I found this really useful, so I added wrappers for setHash and replaceHash methods, which do this out of the box.

Tests, readme, etc. will write if you decide to use my contribution ;)

@millermedeiros
Copy link
Owner

since it's so easy to create the functions (and already on README) I don't see a reason to add it to hasher itself.. I'll keep it open for a few days/weeks to see if anyone else see the value on it, but I won't merge it for now. thanks for your contribution.

@adamlukaszczyk
Copy link
Author

Yes, in README you already have this external method. It wraps "quiet" functionality, so why don't do it in standard way ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants