Skip to content

Fix macOS controls and login items for 2.0.0 - #17

Merged
mimaxon1 merged 1 commit into
mainfrom
fix/macos-controls-2.0.0
Oct 15, 2026
Merged

mimaxon1 merged 1 commit into
mainfrom
fix/macos-controls-2.0.0

Conversation

@mimaxon1

Copy link
Copy Markdown
Owner

Fixes macOS behavior uncovered during the 2.0.0 release review.

  • Read macOS output volume and mute together, so the UI reflects the real mute state and toggles from the system state.
  • Check AppleScript exit status for power commands and show actionable Automation permission errors; declare the Apple Events usage reason in the app bundle.
  • Use SMAppService on macOS 13+ for Login Items, open settings when approval is needed, and retain the LaunchAgent fallback for ad-hoc-signed builds.
  • Label macOS media controls as Music-specific and clarify the platform's power actions in the controller.
  • Update the README, security and testing notes, and allow the release workflow to replace assets with the same names.

Validation: 13 Windows tests pass; Windows release build and Clippy pass; macOS arm64 and x86_64 cross-checks and Clippy pass. Real-Mac TCC prompts and power/media actions still need acceptance on macOS. Media controls intentionally target Music; this patch does not claim global media-key support.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T10:01:55.052419Z 8c302a9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8c302a9869

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/platform.rs
Comment on lines +640 to +641
if status != ServiceStatus::NotRegistered && status != ServiceStatus::NotFound {
return true;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Do not report approval-pending login items as enabled

On macOS 13+, ServiceStatus::RequiresApproval satisfies this condition, even though the service cannot start until the user approves it. After set_autostart explicitly returns an error for that status, the tray immediately changes to “Disable start at login” and --autostart-status reports enabled; clicking the tray item then unregisters the pending service instead of reopening the approval flow. Return true only for an actually enabled SMAppService (or an existing functional legacy item), so pending registrations remain actionable.

Useful? React with 👍 / 👎.

@mimaxon1
mimaxon1 merged commit 2b6f3bd into main Oct 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant