Repository navigation
Fix macOS controls and login items for 2.0.0 - #17
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c302a9869
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if status != ServiceStatus::NotRegistered && status != ServiceStatus::NotFound { | ||
| return true; |
There was a problem hiding this comment.
Do not report approval-pending login items as enabled
On macOS 13+, ServiceStatus::RequiresApproval satisfies this condition, even though the service cannot start until the user approves it. After set_autostart explicitly returns an error for that status, the tray immediately changes to “Disable start at login” and --autostart-status reports enabled; clicking the tray item then unregisters the pending service instead of reopening the approval flow. Return true only for an actually enabled SMAppService (or an existing functional legacy item), so pending registrations remain actionable.
Useful? React with 👍 / 👎.
Fixes macOS behavior uncovered during the 2.0.0 release review.
Validation: 13 Windows tests pass; Windows release build and Clippy pass; macOS arm64 and x86_64 cross-checks and Clippy pass. Real-Mac TCC prompts and power/media actions still need acceptance on macOS. Media controls intentionally target Music; this patch does not claim global media-key support.