Repository navigation
Add sorting options to the Monitor view - #247
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b35db7963d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const sort = page.getByRole('combobox', { name: 'Sort sessions' }); | ||
| const projects = page.locator('.project-section .project-name'); | ||
|
|
||
| await expect(projects).toHaveText(['web-app', 'api-server', 'cli-tools']); |
There was a problem hiding this comment.
Correct the default-order assertion in the sorting test
With the default fixtures loaded by openClassic(page), both api-server and web-app need attention, but only api-server also has an idle session. sortGroups() in src/routes/(app)/+page.svelte:355-357 prioritizes that idle bucket before modification time, so the actual initial order is ['api-server', 'web-app', 'cli-tools'], unchanged from the parent commit. This assertion therefore fails before either new sort option or preference persistence is tested; update its expected order to match the preserved default behavior.
Useful? React with 👍 / 👎.
|
@codex address that feedback |
sortGroups() ranks a project that has an idle session ahead of one that only needs attention, so the default fixtures order is api-server, web-app, cli-tools. Co-authored-by: Benjamin Dupin <bnjdpn@users.noreply.github.com>
|
@minchenlee Addressed the Codex feedback in 5de2864: the default-order assertion now matches |
…headers on one line The sort select used the native macOS look. It now has the same square box as the view toggle, with a drawn arrow. Below 768px it shows the arrow only and the attention badge uses its short label, so the header does not wrap. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FXb4ofqTMSGwAYLtBKW82v
…m CI macos-15 artifact) Co-authored-by: Benjamin Dupin <bnjdpn@users.noreply.github.com>
|
@minchenlee I updated the classic visual baselines in 9bf6a1a using the |
…URL to cover Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FXb4ofqTMSGwAYLtBKW82v
…control Taken from the classic-visual-report artifact of CI run 44220222671 (macos-15). No locally rendered images. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FXb4ofqTMSGwAYLtBKW82v
Keeps both the sort tests from minchenlee#247 and the card option tests. Screenshot conflicts take this branch's images; CI-made baselines follow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FXb4ofqTMSGwAYLtBKW82v
…nto the card options Taken from the classic-visual-report artifact of CI run 44225340450 (macos-15). Settings About no longer shows the Glass switch (minchenlee#249). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FXb4ofqTMSGwAYLtBKW82v
…248) * feat: show model and reasoning effort in Monitor * feat: customize Monitor cards and show active turn duration * feat: track working duration across Monitor providers * test(visual): update classic baselines for Monitor card options (from CI macos-15 artifact) Co-authored-by: Benjamin Dupin <bnjdpn@users.noreply.github.com> * test(visual): update classic baselines after merging #247 into the card options Taken from the classic-visual-report artifact of CI run 44225340450 (macos-15). Settings About no longer shows the Glass switch (#249). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FXb4ofqTMSGwAYLtBKW82v --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Benjamin Dupin <bnjdpn@users.noreply.github.com> Co-authored-by: minchenlee <110967458+minchenlee@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Summary
Add a sort selector to the Classic Monitor so users juggling multiple sessions can find a project by name or see which project was active most recently.
The selection is saved locally and applies across Project, Show All, and Dense views.
Testing
npm run checknpm run lint:dataandnpm run test:lint-datanode --test scripts/test-dense-layout.mjs(7 passed)Visual baselines
The new selector intentionally changes Classic Monitor screenshots. Before/after capture and regeneration of the affected baselines on the macOS WebKit runner are pending.