Skip to content

Customize Monitor cards and show model, effort, and working duration - #248

Merged
minchenlee merged 7 commits into
minchenlee:mainfrom
bnjdpn:feature/monitor-model-effort
Nov 18, 2026
Merged

minchenlee merged 7 commits into
minchenlee:mainfrom
bnjdpn:feature/monitor-model-effort

Conversation

@bnjdpn

@bnjdpn bnjdpn commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Add Settings → Monitor controls for model, reasoning effort, working duration, Git branch, message count, cost or tokens, and session age. Preferences are saved locally and apply to Classic Monitor cards and Dense rows. Existing layout rules for Compact cards still apply.

  • The working timer appears for every provider while the session is Working. Codex uses its recorded turn start when available. For other sessions the timer starts when Monitor first observes the current Working state, and the tooltip identifies that estimate. The observation survives changing tabs or hiding the field and resets when the session leaves Working or disappears.
  • Codex and Pi display the model and effort when reported. Claude Code displays the latest model found in its recent assistant transcript entries. The card omits unavailable values. The current Cursor and OpenCode readers do not report model or effort.
  • Optional metadata is carried by both legacy and engine-backed session payloads.

Verification

  • Frontend type checks and production build passed.
  • 691 Rust session and wire tests passed (13 existing tests ignored), including Codex turn timing and Pi model/effort updates.
  • Frontend IPC contract passed. A focused store check covered observation across provider keys, refreshes, idle transitions, and removal.
  • Added a Playwright scenario for the reported and observed timers and independent saved preferences. WebKit could not launch locally due to missing system libraries. The affected Monitor and Settings screenshots need review and baseline refresh on macOS WebKit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T17:34:06.303322Z c34736a New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@bnjdpn bnjdpn changed the title Show model and reasoning effort in Monitor Customize Monitor cards and show model, effort, and working duration Nov 12, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c34736aff0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

<nav class="settings-nav" aria-label="Settings sections">
{#if nativeNotifications}<button class:active={activeSection === 'notifications'} aria-current={activeSection === 'notifications' ? 'page' : undefined} onclick={() => activeSection = 'notifications'}>Notifications</button>{/if}
<button class:active={activeSection === 'usage'} aria-current={activeSection === 'usage' ? 'page' : undefined} onclick={() => activeSection = 'usage'}>Usage</button>
<button class:active={activeSection === 'monitor'} aria-current={activeSection === 'monitor' ? 'page' : undefined} onclick={() => activeSection = 'monitor'}>Monitor</button>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Refresh Classic screenshot baselines with the UI changes

The existing Classic Settings snapshot tests still use the unchanged settings-*.png baselines, so adding this unconditional navigation button creates a screenshot mismatch even when the feature works correctly. tests/visual/playwright.config.ts requires maxDiffPixels: 0 and threshold: 0, and .github/workflows/ci.yml:124-126 runs those comparisons as a blocking step on the pinned macOS runner. Regenerate and commit the affected baselines with this UI change; the default-on duration labels likewise require updated Monitor baselines.

Useful? React with 👍 / 👎.

bnjdpn commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

@codex address that feedback

bnjdpn commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

@minchenlee About the Codex feedback: the new Monitor nav button and the default-on duration label intentionally change 12 classic baselines, and per tests/visual/README.md they can only be regenerated on the macos-15 runner with Playwright 1.64.1, so I didn't commit Linux-rendered PNGs.

Affected files (tests/visual/classic/__screenshots__/):

  • settings-notifications, settings-usage, settings-integration, settings-remote-access, settings-about
  • monitor-all, monitor-compact, monitor-dense, monitor-dense-compact, monitor-project-tall, demo-monitor, demo-monitor-window

The other 27 baselines should stay byte-identical. Could you regenerate those 12 on macOS (npm ci && npx playwright install webkit && npm run test:visual:update) and commit only the changed files, or tell me how you'd prefer to handle it? Thanks!

cursoragent and others added 2 commits November 17, 2026 09:38
… CI macos-15 artifact)

Co-authored-by: Benjamin Dupin <bnjdpn@users.noreply.github.com>
Bring in minchenlee#249. Settings keeps the Monitor section and shows the Glass
switch only when glassAvailable is set. settings-about.png stays the
Monitor-era CI baseline; a release build no longer draws that switch,
so the About shot needs another macos-15 refresh.

Co-authored-by: Benjamin Dupin <bnjdpn@users.noreply.github.com>

bnjdpn commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

@minchenlee Merged latest main (incl. #249) into this branch in 5df868c and updated the 12 classic baselines from the CI macos-15 classic-visual-report artifact (no locally rendered PNGs). Could you approve the workflow run when you have a moment? Heads-up: settings-about.png will likely still differ, since #249 now hides the Glass switch in release builds; I'll refresh that one from the next CI artifact. Thanks!

minchenlee and others added 2 commits November 18, 2026 10:43
Keeps both the sort tests from minchenlee#247 and the card option tests.
Screenshot conflicts take this branch's images; CI-made baselines follow.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FXb4ofqTMSGwAYLtBKW82v
…nto the card options

Taken from the classic-visual-report artifact of CI run 44225340450
(macos-15). Settings About no longer shows the Glass switch (minchenlee#249).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FXb4ofqTMSGwAYLtBKW82v
@minchenlee
minchenlee merged commit 0498596 into minchenlee:main Nov 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants