Repository navigation
Customize Monitor cards and show model, effort, and working duration - #248
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c34736aff0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <nav class="settings-nav" aria-label="Settings sections"> | ||
| {#if nativeNotifications}<button class:active={activeSection === 'notifications'} aria-current={activeSection === 'notifications' ? 'page' : undefined} onclick={() => activeSection = 'notifications'}>Notifications</button>{/if} | ||
| <button class:active={activeSection === 'usage'} aria-current={activeSection === 'usage' ? 'page' : undefined} onclick={() => activeSection = 'usage'}>Usage</button> | ||
| <button class:active={activeSection === 'monitor'} aria-current={activeSection === 'monitor' ? 'page' : undefined} onclick={() => activeSection = 'monitor'}>Monitor</button> |
There was a problem hiding this comment.
Refresh Classic screenshot baselines with the UI changes
The existing Classic Settings snapshot tests still use the unchanged settings-*.png baselines, so adding this unconditional navigation button creates a screenshot mismatch even when the feature works correctly. tests/visual/playwright.config.ts requires maxDiffPixels: 0 and threshold: 0, and .github/workflows/ci.yml:124-126 runs those comparisons as a blocking step on the pinned macOS runner. Regenerate and commit the affected baselines with this UI change; the default-on duration labels likewise require updated Monitor baselines.
Useful? React with 👍 / 👎.
|
@codex address that feedback |
|
@minchenlee About the Codex feedback: the new Monitor nav button and the default-on duration label intentionally change 12 classic baselines, and per Affected files (
The other 27 baselines should stay byte-identical. Could you regenerate those 12 on macOS ( |
… CI macos-15 artifact) Co-authored-by: Benjamin Dupin <bnjdpn@users.noreply.github.com>
Bring in minchenlee#249. Settings keeps the Monitor section and shows the Glass switch only when glassAvailable is set. settings-about.png stays the Monitor-era CI baseline; a release build no longer draws that switch, so the About shot needs another macos-15 refresh. Co-authored-by: Benjamin Dupin <bnjdpn@users.noreply.github.com>
|
@minchenlee Merged latest |
Keeps both the sort tests from minchenlee#247 and the card option tests. Screenshot conflicts take this branch's images; CI-made baselines follow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FXb4ofqTMSGwAYLtBKW82v
…nto the card options Taken from the classic-visual-report artifact of CI run 44225340450 (macos-15). Settings About no longer shows the Glass switch (minchenlee#249). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FXb4ofqTMSGwAYLtBKW82v
Summary
Add Settings → Monitor controls for model, reasoning effort, working duration, Git branch, message count, cost or tokens, and session age. Preferences are saved locally and apply to Classic Monitor cards and Dense rows. Existing layout rules for Compact cards still apply.
Verification