Repository navigation
i18n: make English the source text (Chinese becomes a catalog) - #3
Merged
Merged
Conversation
Output of scripts/codemod-english-source.ts plus the hand-made parts: t()/tx() ids, KINDS, examples, scenarios and the 17 practice questions are English; src/i18n/zh-TW.ts (English id -> Traditional Chinese) replaces src/i18n/en.ts. Thirteen English texts with two Chinese texts carry a context mark (Off@@not-used) that t() strips. Old Chinese ids in saved designs still translate in English mode. One English text changes: the saas-instagram PostgreSQL label was 61 characters, over the 60-character label limit, and is now "PostgreSQL (12 shards, replicas in another AZ)" (lead decision). Golden hashes do not change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
i18n:check lists entries without Traditional Chinese and passes; it still fails on placeholder mismatches and an out-of-date zh-TW.ts. i18n:strict (nightly on main) fails on missing Chinese. AGENTS.md, CONTRIBUTING.md and docs/design-system.md say English is the source text. schema/design.schema.json descriptions are now English (191 lines). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Assertions on message ids and raw example data use the English ids; assertions on zh-TW output stay and go through t(). The text dump used for the acceptance check runs only with DUMP_OUT set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An example added in English only leaves its zh-TW entry empty, so zh-TW shows English. Only require Chinese when the catalog has it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR #2 added nightly.yml with its own schedule and concurrency group, so ci.yml goes back to main's version and the nightly translation check becomes a job next to the slow tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
t() stripped the @@context from any text, so a scenario named "壓測@@臺北" showed as "壓測" in both languages. Only a catalog id has a context mark now; other text stays as written. Catalog lookups use Object.hasOwn. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The check only looked at the Traditional Chinese title, so an English
title with no translation ("Database failure") passed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
"Replica reads" -> "Read replica count", "Replica applies write cost" -> "Replica write-apply cost", "Not enough result" -> "Insufficient data" (with the three import messages that start with it). The Traditional Chinese moves with each id and does not change. Regenerated schema/ and the AI guide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Built-in scenario names are English now. An old share link or a saved version still has the Traditional Chinese name, so the menu did not mark the current preset. presetOf() (src/app/presetName.ts) also matches the Chinese name in zh-TW.ts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The English source text conversion is done and checked; copies stay with the validation data outside the repo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make English the source text of the UI. Chinese (zh-TW) becomes a translation catalog.
What changes
src/i18n/zh-TW.tsmaps English → Chinese.npm run i18n:check, not an error, so contributors can add English-only examples and practice questions. The nightly job still checks that Chinese is complete.Review
Tests
CI on this PR:
checkande2e.🤖 Generated with Claude Code
https://claude.ai/code/session_015uxaDTazJv7ozbPd3u5Cub