Repository navigation
Add a theme-matched preview modal with pinch zoom and pan - #83
Open
chungchihhan wants to merge 1 commit into
Open
chungchihhan wants to merge 1 commit into
chungchihhan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking a diagram or image now opens a centered, rounded preview modal instead of covering the entire app. An opaque, theme-matched panel sits above a translucent scrim; close it with the close button, Escape or an outside click.
The preview supports native macOS trackpad pinch zoom, pixel-scroll panning and drag-to-pan. Mouse-wheel steps continue to zoom. A local adaptation of Iced’s image viewer retains its MIT notice.
This PR contains only preview UI and gesture routing. It branches directly from upstream main and does not depend on #82 or the reading-width slider. Renderer, dependencies and project-control documents are unchanged. It is separated from the renderer PR as requested in review; it may need rebasing after the pointer-support PRs land.
Validation:
cargo check --locked,cargo fmt --all --checkandgit diff --checkpassed on macOS arm64. Existing import/future-compatibility warnings remain. No automated test suite or fresh standalone native visual check was run; the UI was previously tried as part of the combined experimental build. Manual checks: light/dark modal and scrim, outside-click/Escape, pinch zoom around the pointer, pixel-scroll pan and mouse dragging.