Fix MaProTable pagination reset issue in onSearchSubmit#700
Closed
Fix MaProTable pagination reset issue in onSearchSubmit#700
Conversation
Author
|
@zds-s 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Copilot
AI
changed the title
[WIP] [BUG] MaProTable的onSearchSubmit事件重置分页数据无效
Fix MaProTable pagination reset issue in onSearchSubmit
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MaProTable component's
onSearchSubmitcallback was not properly resetting pagination UI state when form parameters were modified. This caused the pagination component to remain on the previous page number after performing a search, even though the API request and data were correctly reset to page 1.Problem
When users navigate to page 2 of a table and then perform a search:
The API would receive the correct
page=1parameter and return page 1 data, but the pagination component UI would still display "Page 2" causing user confusion.Root Cause
The MaProTable component has two separate concerns:
onSearchSubmitWhen
onSearchSubmitmodifies form parameters, the changes are applied to the API request but the pagination component's internalcurrentPagestate remains unchanged.Solution
Added a workaround that manually synchronizes the pagination UI state after form parameter modification:
The
setTimeoutis necessary because MaProTable processes theonSearchSubmitreturn value asynchronously, and the pagination UI state needs to be updated after the component has processed the form changes.Testing
To verify the fix:
This ensures proper user experience where the pagination component accurately reflects the current page state after search operations.
Fixes #699.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.