Custom fields

[tomtaylor]

I've added the ability to log custom fields from the event payload. It should be pretty straightforward, but let me know if you have any concerns.

[tomtaylor]

Any thoughts on this?

[chrislloyd]

@tomtaylor sorry, I've been busy on other projects. I'm going to get around to doing a little maintenance on this soon. However, I thought it was a bit kludgy that you had to add the keys to the payload and then tell Scrolls::Rails to use those keys. Would it be possible to refactor this patch so Scrolls::Rails doesn't need to be configured?

[tomtaylor]

No problem, thanks for your reply.

My rationale was that other plugins or your own code can interfere with the payload too, for other purposes, so it seemed to make sense to separate those concerns, and ensure that only the fields requested are logged in Scrolls::Rails.

On 7 Oct 2013, at 19:54, Chris Lloyd notifications@github.com wrote:

@tomtaylor sorry, I've been busy on other projects. I'm going to get around to doing a little maintenance on this soon. However, I thought it was a bit kludgy that you had to add the keys to the payload and then tell Scrolls::Rails to use those keys. Would it be possible to refactor this patch so Scrolls::Rails doesn't need to be configured?

—
Reply to this email directly or view it on GitHub.