Adding exception event handing to process_action when not an exception object.

.gitignore

@@ -1,2 +1,3 @@
 pkg
 Gemfile.lock
+.bundle

Gemfile

@@ -1,2 +1,6 @@
 source 'https://rubygems.org'
 gemspec
+
+group :development do
+  gem 'minitest'
+end

Rakefile

@@ -1 +1,8 @@
 require 'bundler/gem_tasks'
+require 'rake/testtask'
+
+Rake::TestTask.new do |t|
+  t.libs << "test"
+  t.test_files = FileList['test/test_*.rb', 'test/**/test_*.rb']
+  t.verbose = true
+end

lib/scrolls/rails/log_subscriber.rb

@@ -13,7 +13,16 @@ class LogSubscriber < ActiveSupport::LogSubscriber
 
       def process_action(event)
         exception = event.payload[:exception]
-        if exception
+
+        if exception.present?
+          # In Rails 3.2.9 event.payload[:exception] was changed from an
+          # Exception object to an Array containing the e.class.name and
+          # e.message. Adding handling for this case here.
+          if exception.is_a?(Array)
+            exception_class_name, exception_message = exception
+            exception = exception_class_name.constantize.new(exception_message)
+          end
+
           Scrolls.log_exception({status: 500}, exception)
         else
           Scrolls.log(extract_request_data_from_event(event))

lib/scrolls/rails/version.rb

@@ -1,5 +1,5 @@
 module Scrolls
   module Rails
-    VERSION = '0.0.1'
+    VERSION = '0.0.2'
   end
 end

test/rails/test_log_subscriber.rb

@@ -0,0 +1,57 @@
+require 'minitest/autorun'
+
+require 'active_support/core_ext/object' # provides .present? && constantize
+require 'scrolls/rails/log_subscriber'
+
+class FakeEvent
+  attr_accessor :payload
+end
+
+# mock Scrolls to something useful for this test
+module Scrolls
+  class << self
+    def log_exception info, ex
+      @@info = info
+      @@ex = ex
+    end
+
+    def info
+      @@info
+    end
+
+    def exception
+      @@ex
+    end
+  end
+end
+
+class ScrollsRailsLogSubscriber < Minitest::Test
+  def setup
+    @sub = Scrolls::Rails::LogSubscriber.new
+    @evt = FakeEvent.new
+  end
+
+  def test_process_action_with_array
+    @evt.payload = {
+      exception: ['Exception', 'Test array']
+    }
+
+    @sub.process_action(@evt)
+
+    assert_equal({status: 500}, Scrolls.info)
+    assert_kind_of(Exception, Scrolls.exception)
+    assert_equal('Test array', Scrolls.exception.message)
+  end
+
+  def test_process_action_with_exception
+    @evt.payload = {
+      exception: Exception.new('Test exception')
+    }
+
+    @sub.process_action(@evt)
+
+    assert_equal({status: 500}, Scrolls.info)
+    assert_kind_of(Exception, Scrolls.exception)
+    assert_equal('Test exception', Scrolls.exception.message)
+  end
+end