Add the Content-Disposition header to attachments#28
Open
BalmungSan wants to merge 5 commits into
Open
Conversation
Owner
|
In this spec https://tools.ietf.org/html/rfc2183 you can see this If add this it should be made as an optional but it will add complexity to email creation. I wanted to remove all headers definitions from users |
Contributor
Author
|
@minosiants as you can see, the header is optional and for now is only used when adding an attachment. I think it can be left like that for now and expanded latter if needed. |
Owner
|
We can keep it open and if we see that it is useful I will merge. |
Contributor
Author
Well I am using it because someone recommended it to me, so no 😉 |
8c0570c to
9bc55b1
Compare
minosiants
reviewed
Nov 28, 2020
3f62a24 to
b075916
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #24
I guess since the job is already done it doesn't hurt to add this, but if you prefer not then I have no objections.