Skip to content

Add the Content-Disposition header to attachments#28

Open
BalmungSan wants to merge 5 commits into
minosiants:masterfrom
BalmungSan:fix-attachment-headers
Open

Add the Content-Disposition header to attachments#28
BalmungSan wants to merge 5 commits into
minosiants:masterfrom
BalmungSan:fix-attachment-headers

Conversation

@BalmungSan

Copy link
Copy Markdown
Contributor

Related to #24

I guess since the job is already done it doesn't hurt to add this, but if you prefer not then I have no objections.

@minosiants

minosiants commented Nov 27, 2020

Copy link
Copy Markdown
Owner

In this spec https://tools.ietf.org/html/rfc2183 you can see this

Content-Disposition is an optional header field. In its absence, the
   MUA may use whatever presentation method it deems suitable.

If add this it should be made as an optional but it will add complexity to email creation. I wanted to remove all headers definitions from users

@BalmungSan

Copy link
Copy Markdown
Contributor Author

@minosiants as you can see, the header is optional and for now is only used when adding an attachment. I think it can be left like that for now and expanded latter if needed.
Or, if you prefer, we can just close this.

@minosiants

Copy link
Copy Markdown
Owner

We can keep it open and if we see that it is useful I will merge.
Thanks a lot for your contribution 👍 . I think your are THE FIRST who is using this lib

@BalmungSan

Copy link
Copy Markdown
Contributor Author

I think your are THE FIRST who is using this lib

Well I am using it because someone recommended it to me, so no 😉

@BalmungSan BalmungSan force-pushed the fix-attachment-headers branch 3 times, most recently from 8c0570c to 9bc55b1 Compare November 27, 2020 22:50
@BalmungSan BalmungSan changed the title Adding the Content-Disposition header to attachments Adding the Content-Disposition header to attachments and fixing its chunking Nov 28, 2020
Comment thread src/main/scala/com/minosiants/pencil/Smtp.scala
@BalmungSan BalmungSan changed the title Adding the Content-Disposition header to attachments and fixing its chunking Adding the Content-Disposition header to attachments Nov 28, 2020
@BalmungSan BalmungSan changed the title Adding the Content-Disposition header to attachments Add the Content-Disposition header to attachments Nov 28, 2020
@BalmungSan BalmungSan force-pushed the fix-attachment-headers branch from 3f62a24 to b075916 Compare November 28, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants