Merge latest dev to main for a new release (v0.3.1)#47
Merged
Conversation
The Statement of need has been revised according to the feedback provided by Reviewer 1 in the JOSS submission review. Additional references have been added. The explanation about the notion of the curse of dimensionality has been expanded in Section 3 (Package Overview). Finally, found typos have been fixed. This commit should resolve Issue #10, #14, and #16.
Following a remark by Reviever 2, the statement of need of the paper has been updated to have a clearer comparison with other packages and how Minterpy is different. This commit should resolve Issue #10.
Following remarks from the reviewers, broken links in README.md has been fixed and the whole file has been revised for clarity. Additionally, CONTRIBUTING.md has also been revised by fixing any broken and stale links and any obsolete information. When applicable, references are made to the online documentation. This commit should resolve Issue #11 and #15.
A paragraph has been expanded to include a commentary on the trade-off between the accuracy of global polynomials and the cost of their evaluation, especially in comparison to B-splines and local piecewise polynomials. This commit should resolve Issue @17.
The Quickstart guide has been revised to fix typos and grammatical mistakes. Furthermore, several sentences have been reformulated for clarity. This commit should resolve Issue #21.
`actions/upload-artifact@v3` has been deprecated and causes the CI/CD pipeline to break. The version used has been updated to v4. Due to some changes in v4, each uploaded artifacts are now explicitly named according to their steps in the workflows. This commit should resolve Issue #30.
Use updated upload artifact GitHub action
Fix issue with the Quickstart Guide
The in-depth tutorial on the one-dimensional polynomial interpolation has been revised to fix typos and grammatical mistakes. Several sentences have been reformulated to enhance clarity. This commit should resolve Issue #22.
Revise the tutorial on 1D poly. interpolation
The in-depth tutorial on the multivariate polynomial interpolation has been revised to fix typos and grammatical mistakes. Several sentences have been rephrased to enhance clarity. This commit should resolve Issue #23.
Revise the tutorial on mD poly. interpolation
The in-depth tutorial on the arithmetic operations with Minterpy polynomials has been revised to fix typos and grammatical mistakes as well as reformulate sentences to enhance clarity. This commit should resolve Issue #24.
Revise the tutorial on arithmetic operations with poly.
The in-depth tutorial on the calculus operations with Minterpy polynomials has been revised to fix typos and grammatical mistakes as well as reformulate sentences to enhance clarity. This commit should resolve Issue #25.
Revise the tutorial on calculus operations with poly.
The in-depth tutorial on the polynomial bases and the transformation between them has been revised to fix typos and grammatical mistakes. Furthermore, several sentences have been reformulated to enhance clarity. This commit should resolve Issue #26.
Revise the tutorial on polynomial bases and transformation
The in-depth tutorial on the polynomial regression has been revised to fix typos and grammatical mistakes. Furthermore, several sentences have been reformulated to enhance clarity. This commit should resolve Issue #27.
Revise the tutorial on polynomial regression
Several issues found in the main page of the Getting Started Guide have been fixed. They include correct default location for the Minterpy repository and some sentences reformulation to enhance clarity. This commit should resolve Issue #20.
Revise the main page of Getting Started Guide
Some of the documentation tooling mentioned in the contributors guide is obsolete and has been updated. This commit should resolve Issue #28.
Fix stale information on the contributors guide
Revert " Fix stale information on the contributors guide"
Some of the documentation tooling mentioned in the contributors guide is obsolete and has been updated. This commit should resolve Issue #28.
Fix stale information on the contributors guide
The landing page has been revised for consistency and the version that appear on the page has been fixed to display the correct version. This commit should resolve Issue #19.
Revise landing page and displayed version information
The draft manuscript submitted to the Journal of Open Source Software (JOSS) has been revised in accordance with the JOSS review process. Additionally, some elements of the documentation have been updated accordingly. Specific changes made: - Added commentary on the trade-off between accuracy and cost using global polynomials, especially in comparison to B-splines and local piecewise polynomials, which should resolve Issue #17. - Updated README.md and CONTRIBUTING.md to fix broken links, update obsolete information, and improve clarity. References to the online documentation have also been made where applicable, resolving Issues #11 and #13. - Revised AUTHORS.md to match the credits listed in README.md. - Added a reference to the archived numerical experiment. - Revised the statement of need and package overview in the paper following feedback from Reviewer 1. An explanation about the curse of dimensionality has been added to Section 3, resolving Issues #10, #14, and #16. - Updated the statement of need with a clearer comparison to other packages following a remark by Reviewer 2, resolving Issue #10. - Update the reference with the most recent Minterpy reference paper. --------- Co-authored-by: Juanjo Bazán <jjbazan@gmail.com>
This commit includes several updates to prepare Minterpy for a new release following the review process of its submission to the Journal of Open Source Software (JOSS). Notable changes: - Updated repository URL and Issue Tracker URL in `setup.cfg` and revised classifiers. - Added JOSS badge to `README.md`. - Removed GitHub Actions workflow for building the draft PDF. - Updated `CHANGELOG.md` to reflect changes. This commit resolves Issue #45.
Prepare for new release after JOSS review
Contributor
|
Documentation preview (without executed notebooks) is available. |
Contributor
|
Documentation preview (without executed notebooks) is available. |
Remove unnecessary GitHub Action workflow
Contributor
|
Documentation preview (without executed notebooks) is available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest
devbranch will be merged themainbranch from which a new tagv0.3.1will be created.