Skip to content

Force fontconfig-parser version to v0.5.7 #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ImplOfAnImpl merged 1 commit into from
Aug 5, 2025
Merged

Force fontconfig-parser version to v0.5.7 #1947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,3 +286,14 @@ opt-level = 2
[features]
trezor = []
default = ["trezor"]

[patch.crates-io]
# Using fontconfig-parser v0.5.8 completely breaks UI in node-gui on Linux - most of the text disappears and the few
# characters that remain have broken spacing, so we force the usage of v0.5.7 via "patch".
# Note: the commit is called "Bump version" and it's where the version was bumped to "0.5.7"; it is the last "good"
# revision. The following ("bad") revision belongs to the PR https://github.com/Riey/fontconfig-parser/pull/11 which
# claims to fix certain issues. So it's possible that fontconfig-parser v0.5.8 is actually good, but a dependent crate
# uses it incorrectly (so v0.5.7 works only because several bugs cancel each other out). The current dependency chain
# is fontconfig-parser <- fontdb <- cosmic-text <- various "iced" crates.
# TODO: investigate this further.
fontconfig-parser = { git = "https://github.com/Riey/fontconfig-parser", rev = "f7d13a779e6ee282ce75acbc00a1270c0350e0c2" }
Loading