Skip to content

Improvements related to wallet-cli pagination mode - #1954

Merged
ImplOfAnImpl merged 1 commit into
masterfrom
improve_wallet_cli_pagination
Aug 18, 2025
Merged

Improvements related to wallet-cli pagination mode#1954
ImplOfAnImpl merged 1 commit into
masterfrom
improve_wallet_cli_pagination

Conversation

@ImplOfAnImpl

@ImplOfAnImpl ImplOfAnImpl commented Aug 15, 2025

Copy link
Copy Markdown
Contributor

At the start of paginate_output:

  1. Disable direct logging, so that the output is not polluted with logs (which will appear broken in the raw terminal mode anyway).
  2. Enter the alternate terminal screen, so that the existing contents of the terminal window is preserved.

Base automatically changed from prettify_wallet_cli_help to master August 18, 2025 10:55
@ImplOfAnImpl
ImplOfAnImpl merged commit a6db1a1 into master Aug 18, 2025
14 checks passed
@ImplOfAnImpl
ImplOfAnImpl deleted the improve_wallet_cli_pagination branch August 18, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner
1 more reviewer
@OBorce OBorce OBorce approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ImplOfAnImpl @OBorce