Partially signed tx in wasm wrappers - #1970
Merged
Merged
Conversation
…_signed_transaction in wasm bindings
OBorce
approved these changes
Sep 18, 2025
| /// | ||
| /// The number of items in each list must be equal to the number of transaction inputs. | ||
| /// | ||
| /// `additional_info` has the same meaning as in `encode_witness`. |
Contributor
There was a problem hiding this comment.
additional_info has the same meaning as described in encode_witness
Contributor
Author
There was a problem hiding this comment.
additional_infohas the same meaning as described inencode_witness
[discussed] "as described in encode_witness" sounds a bit off - "encode_witness" is a function, so the parameter cannot be "described in" it.
Leaving it as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
encode_partially_signed_transactionwas added (other added functions areencode_destination, which is needed to produce input destinations usable byencode_partially_signed_transaction, anddecode_partially_signed_transaction_to_js, which is used for testing).PartiallySignedTransactionwas moved tocommon.PartiallySignedTransactionno longer contains token infos. This is because they are a temporary trezor-specific solution, which would have to be removed in the future anyway. And since we're beginning to exposePartiallySignedTransactionto other teams, now is the good time to do it.(To be clear, the token infos are still collected in the wallet and passed to trezor as before, they just aren't part of
PartiallySignedTransactionanymore. The proper approach to passing token infos to trezor was described here).