Skip to content

Guessed "transaction type" depends on the order of outputs #21

Description

@ImplOfAnImpl

The app has a logic to determine the "type" of the transaction, to show during review. There are simple types, e.g. "Transfer", "Burn", "Htlc", "FillOrder", which are selected when the tx has the corresponding input/ output but nothing else (except for simple transfers), and one "ComplexTransaction", which is selected when the tx has mixed inputs/outputs. The problem is that "Transfer" outputs are treated in a special way during the "type" selection (because they can be change outputs), so a tx with "Burn" and "Transfer" outputs (in that order) will be classified as "Burn", and if the outputs are "Transfer" and "Burn"", then it'll be classified as "Transfer".
See the TODO near merge_tx_type in crates/app-core/src/handlers/sign_tx/summary_collector.rs.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions