Skip to content

Mintlayer app - new main PR - #7

Merged
ImplOfAnImpl merged 400 commits into
masterfrom
feature/refactor-too-big
Jul 2, 2026
Merged

Mintlayer app - new main PR#7
ImplOfAnImpl merged 400 commits into
masterfrom
feature/refactor-too-big

Conversation

@ImplOfAnImpl

@ImplOfAnImpl ImplOfAnImpl commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

This supersedes #1, which has too many comments and is hard to navigate.

Note:

  1. The code in the two PRs have diverged as they contain two different refactorings, see Feature/mintlayer app #1 (comment)
  2. Some review comments from the old PR may still be relevant, so all the comments must be rechecked.

bboilot-ledger and others added 30 commits March 28, 2024 10:07
@bboilot-ledger
Update rust SDK and fix keccak256 declaration
223e5e5
@bboilot-ledger
Update nanox and nanos golden snapshots
015f922
@bboilot-ledger
Merge pull request #57 from LedgerHQ/bboilot/update_sdk
064b0aa 
Update rust SDK and fix keccak256 declaration
@bboilot-ledger
Move rustup default next to rustup install
7873f48
@bboilot-ledger
Merge pull request #56 from brianp/readme-fixes
8a0fdd7 
Readme fixes
@yogh333
Merge pull request #54 from LedgerHQ/yogh333/update_readme
1611150 
Update Readme: Ragger tests can be launched without duplicating build…
@agrojean-ledger
Add Stax support
83e42d3
@agrojean-ledger
Small updates for NBGL sync integration.
870a751
@agrojean-ledger
Use new include_gif macro to generate NBGL glyphs.
7e319a9
@agrojean-ledger
Update code + test snapshots following C string conversion support in…
a977014 
… Rust SDK.
@agrojean-ledger
Add Flex support.
e74326d
@agrojean-ledger
Add settings example.
e4f0c88
@agrojean-ledger
Add dashboard icons for Stax and Flex.
dfafdff
@agrojean-ledger
Update tests snapshots following version bump in Cargo.toml
10281b3
@agrojean-ledger
Use init_comm from nbgl rust module to initialize Comm object reference
98648b3 
used by nbgl api calls.
@agrojean-ledger
Update test_version test to parse version directly from Cargo.toml
240f7a0
@agrojean-ledger
Update get pub key tests snapshots to show status screens.
5a00f1a
@agrojean-ledger
Update cargo.lock
6d6be89
@agrojean-ledger
Fix TOML parsing library import.
cc5c0c8
@agrojean-ledger
Fix static analysis.
afd5bb8
@agrojean-ledger
Fix icon files bit depth and update tests snapshots.
779deec
@agrojean-ledger
Update README
b09dcc1
@agrojean-ledger
PR review.
02b1c32
@agrojean-ledger
Update usage.md
46a0075
@agrojean-ledger
Merge pull request #49 from LedgerHQ/test-stax-build
2aa6e97 
Add Stax and Flex support
@agrojean-ledger
Update SDK version for lock-screen fix on Stax / Flex.
4887fa2
@agrojean-ledger
Merge pull request #59 from LedgerHQ/update-sdk
57d01bd 
Update SDK version for lock-screen fix on Stax / Flex.
@kingofpayne @yogh333
Use of heap feature for simpler code
9ec3374
@yogh333
Ragger tests OK for Nano S+,X, Stax and Flex
52f7992
@yogh333
Use last Rust SDK + Bump version
0e52ff5
@ImplOfAnImpl
ImplOfAnImpl requested a review from anyxem June 30, 2026 10:49
ImplOfAnImpl and others added 23 commits June 30, 2026 14:43
@ImplOfAnImpl
Add codecheck script
4e50569
@ImplOfAnImpl
Replace FIXMEs with TODOs, minor cleanup
23e0788
@ImplOfAnImpl
Check derivation path in SignMessage
16b5457
@ImplOfAnImpl
Avoid using from_utf8_lossy when displaying strings; show "descriptio…
b5be495 
…n" and "media_hash" during nft issuance review.
@ImplOfAnImpl
Cleanup tests/application_client/__init__.py, add some TODOs
2dfdfb2
@ImplOfAnImpl
Rename tests/test_sign_cmd.py to tests/test_sign_tx.py
3c62460
@ImplOfAnImpl
Minor cleanup in tests
8dd0329
@ImplOfAnImpl
Move test-related utils to a separate crate. Bump rust edition of app…
df345f1 
…-core to 2024
@ImplOfAnImpl
Add tests for ledger-messages; fix Apdu::new_chunks for the case of e…
3ed2067 
…mpty data.
@ImplOfAnImpl
Replace a FIXME with a TODO
954a040
@ImplOfAnImpl
Bump version to 1.0.0
dc06375
@ImplOfAnImpl
Temporarily disable guidelines_enforcer job
f8cd9cf
@ImplOfAnImpl
Prettify the code; appease clippy
f2e230a
@ImplOfAnImpl
Run 'cargo clean' in regenerate_snapshots.sh
fef9fc8
@ImplOfAnImpl
Update snapshots
2c2998e
@ImplOfAnImpl
Format token amounts as atoms, instead of using coin-specific formatting
f558aee
@ImplOfAnImpl
Reject txs with zero inputs; some cleanup
6012ea7
@ImplOfAnImpl
Cleanup of tx signing tests
327af45
@ImplOfAnImpl
Check signatures in python tests
15e31ff
@ImplOfAnImpl
Prettify python code
8a8ccc3
@ImplOfAnImpl
Fix CI; cleanup
74d4b2b
@ImplOfAnImpl
Update snapshots
b82dcb1
@ImplOfAnImpl
Merge pull request #9 from mintlayer/app_cleanup
0b975aa 
App cleanup
@ImplOfAnImpl
ImplOfAnImpl merged commit b736f20 into master Jul 2, 2026
33 checks passed
@ImplOfAnImpl
ImplOfAnImpl deleted the feature/refactor-too-big branch July 2, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anyxem anyxem anyxem approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.