Skip to content

App cleanup - #9

Merged
ImplOfAnImpl merged 62 commits into
feature/refactor-too-bigfrom
app_cleanup
Jul 2, 2026
Merged

App cleanup#9
ImplOfAnImpl merged 62 commits into
feature/refactor-too-bigfrom
app_cleanup

Conversation

@ImplOfAnImpl

@ImplOfAnImpl ImplOfAnImpl commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  1. The app can now sign transactions without outputs.
  2. General cleanup was done:
    • Mentions of boilerplate app were removed.
    • Various types were renamed.
    • Mintlayer-specific hashing was encapsulated in the Hasher struct, which implements parity_scale_codec::Output, so temporary allocations during encoding are no longer needed.
    • Documentation was cleaned up.
    • Some cleanup in tests, e.g.: Transaction now contains non-encoded data, unused types were removed from tests/application_client/__init__.py etc.
    • Some other cleanup.

P.S.

  • I left a bunch of FIXMEs, I plan to create an issue for each of them.
  • tools/get_target_id.py was copied from the latest version of the boilerplate app.

@ImplOfAnImpl
Update year in copyrights
cd2ee45
@ImplOfAnImpl
Regenerate all snapshots
02d4cf1
@ImplOfAnImpl
Messages renaming and cleanup - WIP
fc8d8c5
@ImplOfAnImpl
Remove unused types from tests/application_client/__init__.py
ef88f34
@ImplOfAnImpl
Format python code via black
098ff0c
@ImplOfAnImpl
Fix rust-analyzer warning about P2_MORE/P2_DONE having wrong case (it…
8b47b22 
… thinks they're bindings not constants)
@ImplOfAnImpl
Add a bunch of FIXMEs
18ee93e
@ImplOfAnImpl
Send 1st signature after the 1st explicit request rather than after l…
0043ed0 
…ast output (tests not updated)
@ImplOfAnImpl
Update tests: 1) tests fix (as last output no longer returns the 1st …
e61292f 
…sig); 2) remove unused utils, move Transaction to mintlayer_utils; 3) Transaction now contains unencoded data; 4) tx sig check now expects the proper number of signatures and also checks the returned indices.
@ImplOfAnImpl
Add test for ts with zero outputs; some cleanup
507a6aa
@ImplOfAnImpl
Tests improvements: 1) expect specific intermediate responses; 2) som…
aa5b032 
…e cleanup; 3) add tx signing tests with large output/input/commitment.
@ImplOfAnImpl
Fix tests on touch devices (need snapshot update)
6ffed54
@ImplOfAnImpl
Update snapshots
2359083
@ImplOfAnImpl
Add some FIXMEs
b87fdcd
@ImplOfAnImpl
Move the tech spec document to docs and rename it
008a40b
@ImplOfAnImpl
Move icons and glyphs to the media subdir; minor cleanup
949f6da
@ImplOfAnImpl
Move derivation path handling to utils; add a couple of FIXMEs
7193d60
@ImplOfAnImpl
Minor cleanup of tx messages
b941a0c
@ImplOfAnImpl
Regression fix: call ui_approve_streaming_review inside switch_to_sig…
3c00547 
…ning; minor cleanup
@ImplOfAnImpl
Add some FIXMEs
8ab3bfe
@ImplOfAnImpl
Fix docs; minor cleanup; forbid non-empty data in ping command
b845883
@ImplOfAnImpl
Appease clippy
b709a13
@ImplOfAnImpl
Update snapshots
35f5123
@ImplOfAnImpl
Cleanup
1eaef55
@ImplOfAnImpl
Use bigger MAX_BUFFER_LEN; add a fixme; fix some typos
54f8186
@ImplOfAnImpl
Remove the useless subtitle "Cannot be undone" from message signing r…
472ed97 
…eview
@ImplOfAnImpl
Add tools/get_target_id.py (copied from the latest boilerplate app)
4d09da8
@ImplOfAnImpl
Cleanup (mostly docs)
b0dfba3
@ImplOfAnImpl
Update tests.usage.md to refer to the main readme for device installa…
d0d0acb 
…tion instructions
@ImplOfAnImpl
The messages crate now re-exports all types from mintlayer_core_primi…
f526cc8 
…tives
@ImplOfAnImpl
ImplOfAnImpl requested a review from anyxem June 30, 2026 10:49
@ImplOfAnImpl
Add codecheck script
4e50569
@ImplOfAnImpl
Replace FIXMEs with TODOs, minor cleanup
23e0788
@ImplOfAnImpl
Check derivation path in SignMessage
16b5457
@ImplOfAnImpl
Avoid using from_utf8_lossy when displaying strings; show "descriptio…
b5be495 
…n" and "media_hash" during nft issuance review.
@ImplOfAnImpl
Cleanup tests/application_client/__init__.py, add some TODOs
2dfdfb2
@ImplOfAnImpl
Rename tests/test_sign_cmd.py to tests/test_sign_tx.py
3c62460
@ImplOfAnImpl
Minor cleanup in tests
8dd0329
@ImplOfAnImpl
Move test-related utils to a separate crate. Bump rust edition of app…
df345f1 
…-core to 2024
@ImplOfAnImpl
Add tests for ledger-messages; fix Apdu::new_chunks for the case of e…
3ed2067 
…mpty data.
@ImplOfAnImpl
Replace a FIXME with a TODO
954a040
@ImplOfAnImpl
Bump version to 1.0.0
dc06375
@ImplOfAnImpl
Temporarily disable guidelines_enforcer job
f8cd9cf
@ImplOfAnImpl
Prettify the code; appease clippy
f2e230a
@ImplOfAnImpl
Run 'cargo clean' in regenerate_snapshots.sh
fef9fc8
@ImplOfAnImpl
Update snapshots
2c2998e
@ImplOfAnImpl
Format token amounts as atoms, instead of using coin-specific formatting
f558aee
@ImplOfAnImpl
Reject txs with zero inputs; some cleanup
6012ea7
@ImplOfAnImpl
Cleanup of tx signing tests
327af45
@ImplOfAnImpl
Check signatures in python tests
15e31ff
@ImplOfAnImpl
Prettify python code
8a8ccc3
@ImplOfAnImpl
ImplOfAnImpl force-pushed the app_cleanup branch 2 times, most recently from 40961a5 to 2af4e2a Compare July 2, 2026 10:06
@ImplOfAnImpl
ImplOfAnImpl marked this pull request as ready for review July 2, 2026 10:51
@ImplOfAnImpl
ImplOfAnImpl merged commit 0b975aa into feature/refactor-too-big Jul 2, 2026
33 checks passed
@ImplOfAnImpl
ImplOfAnImpl deleted the app_cleanup branch July 2, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anyxem anyxem anyxem approved these changes
@OBorce OBorce Awaiting requested review from OBorce

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ImplOfAnImpl @anyxem