- When delegating, the corresponding dialog says "total amount: xxx \n Including fee: yyy", but the fee is not included in the displayed total amount.
- The fee displayed for order fill transactions is incorrect - it includes the fill amount itself. E.g. when I fill an order for 5 TML, the final confirmation dialog shows 5.289 as the fee, even though the actual fee is only 0.289.
- There are probably other bugs like this.
Besides fixing the bugs, we need more tests:
- Some unit tests for the fee calculation would be nice to have (in
core/tests/).
- We need extensive tests for the UI produced during tx confirmation. Ideally, we should have the tests both in this repo (in
tests/ui_tests/) and in the core repo too. The tests in the core repo may be more extensive, but check the UI for one device model only (it should be possible to check the UI by examining the json returned from the device/emulator via the debug link). The tests in this repo may be less extensive, but check the UI for all the models.
Besides fixing the bugs, we need more tests:
core/tests/).tests/ui_tests/) and in the core repo too. The tests in the core repo may be more extensive, but check the UI for one device model only (it should be possible to check the UI by examining the json returned from the device/emulator via the debug link). The tests in this repo may be less extensive, but check the UI for all the models.