A-1213877919321096: Security - #254
Merged
Merged
Conversation
Introduce a version-aware key size so V3 derives a 256-bit key (AES-256-GCM) while V1/V2 keep their 128-bit keys for backward-compatible decryption of already-stored data. Existing accounts are migrated to V3 on unlock via the existing reEncryptAccount flow. Also guard hexToBytes against null/empty input to avoid a TypeError on malformed data. Adds migration round-trip tests (v1->v2, v2->v3, v1->v3).
Reuse getAccount() instead of repeating loadAccounts()+get(), collapse the duplicate loadAccountSubRoutines() call in reEncryptAccount, and reuse the already-computed accountVersion in unlockAccount. saveAccount no longer derives a key just to obtain a salt: getEncryptedPrivateKeys now generates the salt when none is passed and returns it, removing one expensive PBKDF2 derivation per account creation. Align the unlockAccount rejection shape with its success shape (addresses, btcPrivateKeys) so consumers can destructure consistently on error.
anyxem
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💬 Description
Security improvements
More
📋 Checklist:
A-[id of Asana task]A-[id of Asana task]: [short description]prettierchecklintcheck