Full node id in DB, export and online export#1
Open
palachzzz wants to merge 4 commits intomintylinux:mainfrom
Open
Full node id in DB, export and online export#1palachzzz wants to merge 4 commits intomintylinux:mainfrom
palachzzz wants to merge 4 commits intomintylinux:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Recenly we faced with situation that 4 byte is not enough for online services to distinguish Repeater nodes.
It is clear that 4-byte provides a lot of unique numbers actually 4294967296. But due to existing of
https://github.com/agessaman/meshcore-keygen people are choosing some beauty numbers for their repeaters, like 00000000, 77777777, 34343434 and etc. As it is relatively fast to generate 4-byte pub key buy request, it takes several hours on modern PC.
So to avoid such collisions, I made this PR and some changes, which stores full NodeID and send it full to online services and in JSON export (and probably other types of export).
The code is actually ready to use full node id. Maybe it is even better to add additional field "shortNodeID" and "fullNodeID" to ping result, but as for now I decided to make it less intrusive.
So it still shows 4 bytes in App UI, but internally it is 32 bytes.