Conversation
| match Unix.getaddrinfo host "" [Unix.AI_SOCKTYPE Unix.SOCK_STREAM] with | ||
| | {ai_addr = ADDR_INET(addr, _) ; _} :: _ -> addr | ||
| | [] -> Capnp_rpc.Debug.failf "No addresses found for host name %S" host | ||
| | _ -> Capnp_rpc.Debug.failf "Unknown host %S" host |
There was a problem hiding this comment.
It's a bit odd to say "unknown host" where there are multiple matches.
There was a problem hiding this comment.
Indeed this branch was only taken for Unix sockets.
I updated the match to make it explicit.
However, the message is maybe not so relevant anymore. I kept it as it was before, but maybe it deserves to be reworded a bit
|
Since #284 was merged, this is mostly working now. For example: It would be good to be able to parse numerical IPv6 addresses, as in 'tcp:[::1]:7000', though. I think it does need the brackets; using the |
|
Fixed in #296. I found Thanks! |
The PR following #278
This is adding support for ipv6 in capnp-rpc-unix.
This has been tested with ocurrent rpc on the server and the client.
For 3. I don’t think this is the best way to do : the format of ip6 host would be
tcp:::1:7000which is not so readable.It is probably better to do
tcp:[::1]:7000but this require more change than simply adding~rev:true.Tell me what do you think of it