Fix deprecated QCheck functions in test_lru.ml#2394
Closed
cuihtlauac wants to merge 1 commit into
Closed
Conversation
Update to use non-deprecated QCheck.Gen functions: - frequency -> oneof_weighted - small_int -> nat_small Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
This would require bumping the lower bound on Or we could use #2393 and add an upper bound there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
frequency→oneof_weightedsmall_int→nat_smallProblem
Build fails with recent qcheck-alcotest due to deprecated function alerts being treated as errors.
Test plan
dune buildsucceedsdune runtest test/irminpasses🤖 Generated with Claude Code