Skip to content

Added check to parser header till trailing \r\n#1082

Open
Athishpranav2003 wants to merge 1 commit intomirage:mainfrom
Athishpranav2003:improve-header-parsing
Open

Added check to parser header till trailing \r\n#1082
Athishpranav2003 wants to merge 1 commit intomirage:mainfrom
Athishpranav2003:improve-header-parsing

Conversation

@Athishpranav2003
Copy link

This PR addresses #1032 .
Here we basically raise Exception whenever we find a incorrect section while parsing headers.

Signed-off-by: Athish Pranav D <athishanna@gmail.com>
@Athishpranav2003
Copy link
Author

@rgrinberg can you please check this

@rgrinberg
Copy link
Member

Why do we need a separate exception for invalid headers? Why can't we just raise whatever we raise when we fail to parse the request for any other reason? E.g. Content-Length isn't a valid number for example.

@Athishpranav2003
Copy link
Author

@rgrinberg i cannot find the exception we raise for such issues. Could you please show which exception are you referring to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants