cohttp-eio : split Rwer module into Buf_read and Buf_write. #971
Closed
bikallem wants to merge 1 commit into
Closed
cohttp-eio : split Rwer module into Buf_read and Buf_write. #971bikallem wants to merge 1 commit into
bikallem wants to merge 1 commit into
Conversation
Rwer module mostly served as miscellaneous dump bag of various readers and writers. The name Rwer always felt a bit incoherent even when it was initially added. However, I couldn't quite pin the correct module name for it. Recently, while working on another PR, it dawned on me that the readers and writers can be logically split into Buf_read and Buf_write modules by extending Eio Buf_read and Buf_write modules respectively.
bikallem
force-pushed
the
cleanup-rwer
branch
from
35f18f5 to
9348258
Compare
1 task
Contributor
Author
|
The PR may look big (due to Files changed). However, it is mostly "lift and shift" operation. |
Contributor
Author
|
Closing this in support of discussion happening at #969 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rwer module mostly served as miscellaneous dump bag of various readers and writers. The name Rwer always felt a bit incoherent even when it was initially added. However, I couldn't quite pin the correct module name for it. Recently, while working on another PR, it dawned on me that the readers and writers can be logically split into Buf_read and Buf_write modules by extending Eio Buf_read and Buf_write modules respectively.
Split off from #969 for easy review.
/cc @patricoferris @mseri