Repository navigation
Add brush_maps - #13
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 7, 2026
Closed
Closed
Closed
Closed
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5hif7y
marked this pull request as draft
November 7, 2026 21:24
Member
Author
|
Thanks for the review. I took it a bit differently:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
The two changes this depends on are open: mirai-engine/mirai#2 (install, update and sync check out the submodules of a plugin; closes mirai-engine/mirai#1) and #14 (the validator sees companions held as submodules). The entry now points to |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Changed course: the four companions are now git subtrees instead of submodules, so their files are in this repository and |
5hif7y
marked this pull request as ready for review
November 7, 2026 22:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The map plugins in one catalog entry.
brush_mapsholdsvalve220,map_convert,map_agentandbsp_decompileas its companions inplugins/<name>/, each a git subtree of its own repository: the files are inbrush_maps, so the engine installs it as it is, and each plugin keeps its own repository, tests and history, so it can be audited and debugged on its own. The catalog lists onlybrush_maps; #7, #8, #9 and #10 are closed.map_convert.to_valve220,map_convert.unpack_wad,map_agent.layout,map_agent.check,bsp_decompile.to_valve220.bsp_decompileis the one of ericw-tools, credited in its README.It no longer depends on other changes. Submodules would need mirai-engine/mirai#2 and #14, which stay open on their own as support for plugins that do hold submodules.
Checked against
mainof the engine:uv run scripts/validate.pylistsbrush_maps, bsp_decompile, map_agent, map_convert, valve220.mirai plugin add <this url> --ref <this commit>in an empty project brings the four companions with their files, andbuild editorbuilds them.plugins/brush_maps/plugins/<name>, and so do the same four built alone.valve220installed alone,plugin add brush_mapsis refused: "two folders provide the plugin 'valve220'", and the project is left as it was.🤖 Generated with Claude Code