Repository navigation
Give the engines of the plugin build tests a compressor collection - #105
Merged
Merged
Conversation
The build passes -collection:compressor (and compressor_open) to every plugin library, and odin refuses a collection whose folder is missing. The engines four cook/build tests write had no std/compressor, so their plugin libraries never compiled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fixture_write writes the files of a test's engine and project, with the compressor collection every engine has and the build names, so a fixture lists only what it tests and the next folder the build names is added once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #95.
Changes
project.compressor_flagsgives every plugin compile-collection:compressor=<engine>/std/compressorand-collection:compressor_open=..., and odin refuses a collection whose folder does not exist.coreand their plugins but nostd/compressor.engine/std/compressor/compressor.odin, as a real engine has it. Test files only, +4 lines.std/compressoris broken, and saying so stays right.Tests
cook/buildtests fail onmain: their fixture engine has nocompressorcollection #95 pass, anda_plugin_that_imports_a_plugin_it_does_not_depend_on_is_an_errorbeside them still passes.mirai test cook/build: 115/116. The one left isno_store_of_an_aggregate_of_more_than_64_bytes, which Store the edit layers of a terrain one value per assignment #102 fixes (terrain::source_edit_layer_addstores a 320-byte aggregate at once, whichno_store_of_an_aggregate_of_more_than_64_bytesrefuses #96).🤖 Generated with Claude Code