Skip to content

Weigh the pipeline store's saves by the time measured around creation - #107

Merged
tomaszbk merged 4 commits into
mainfrom
rhi/store-time-without-feedback
Nov 16, 2026
Merged

tomaszbk merged 4 commits into
mainfrom
rhi/store-time-without-feedback

Conversation

@5hif7y

@5hif7y 5hif7y commented Nov 16, 2026

Copy link
Copy Markdown
Member

Closes #92.

On top of #106 (it touches the same lines): merge #106 first, and this PR then shows only its own commit.

Changes

  • vk_pipeline_cache_close (rhi/vulkan_resources.odin) takes took, the time vkCreateComputePipelines or vkCreateGraphicsPipelines ran, measured on the CPU around the call.
  • It no longer reads VkPipelineCreationFeedback.duration, which a driver that does not set VALID leaves at 0. One measure for every driver, instead of the feedback plus a fallback. The feedback still says whether the pipeline came from the blob kept for it.
  • rhi.md says where the time comes from.

Tests

🤖 Generated with Claude Code

5hif7y and others added 2 commits November 15, 2026 20:56
…ords

When pipeline creation returns VK_ERROR_DEVICE_LOST, the validation
layer has not marked the device lost and reports
vkGetDeviceFaultInfoEXT as a validation error. Pipeline creation now
marks the loss without asking for its description.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The time a pipeline added came from VkPipelineCreationFeedback.duration,
which is 0 on a driver that does not set VALID: such a run wrote the
store only at device_destroy, and a killed editor lost all it compiled.
The CPU now measures the creation call, on every driver.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@5hif7y 5hif7y self-assigned this Nov 16, 2026
@5hif7y
5hif7y requested a review from tomaszbk November 16, 2026 00:00
tomaszbk and others added 2 commits November 15, 2026 21:49
…ation layer

The query is valid after any VK_ERROR_DEVICE_LOST; only the validation layer
flags it when no submission or wait reported the loss. Without the layer the
driver's description of such a loss is kept. The workaround is listed under
Drivers in the dependency workarounds.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s' into rhi/store-time-without-feedback

# Conflicts:
#	rhi/vulkan_resources.odin
@tomaszbk
tomaszbk merged commit 4aae7bb into main Nov 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The pipeline store writes nothing during a run when the driver gives no creation feedback

2 participants