Repository navigation
Weigh the pipeline store's saves by the time measured around creation - #107
Merged
Merged
Conversation
…ords When pipeline creation returns VK_ERROR_DEVICE_LOST, the validation layer has not marked the device lost and reports vkGetDeviceFaultInfoEXT as a validation error. Pipeline creation now marks the loss without asking for its description. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The time a pipeline added came from VkPipelineCreationFeedback.duration, which is 0 on a driver that does not set VALID: such a run wrote the store only at device_destroy, and a killed editor lost all it compiled. The CPU now measures the creation call, on every driver. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ation layer The query is valid after any VK_ERROR_DEVICE_LOST; only the validation layer flags it when no submission or wait reported the loss. Without the layer the driver's description of such a loss is kept. The workaround is listed under Drivers in the dependency workarounds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s' into rhi/store-time-without-feedback # Conflicts: # rhi/vulkan_resources.odin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92.
On top of #106 (it touches the same lines): merge #106 first, and this PR then shows only its own commit.
Changes
vk_pipeline_cache_close(rhi/vulkan_resources.odin) takestook, the timevkCreateComputePipelinesorvkCreateGraphicsPipelinesran, measured on the CPU around the call.VkPipelineCreationFeedback.duration, which a driver that does not setVALIDleaves at 0. One measure for every driver, instead of the feedback plus a fallback. The feedback still says whether the pipeline came from the blob kept for it.rhi.mdsays where the time comes from.Tests
mirai check rhi;mirai test rhi: 31/31, includingrhi_kept_pipelines_are_read_back_and_do_not_grow.check_docs.py: nothing new. The two docs it reports arescripts/check_docs.pyfails onmain: two docs over their line limit #94, which Keep two game docs within their line limits #101 fixes.🤖 Generated with Claude Code