Skip to content

Give the catalogs of two render tests the version the parser reads - #108

Merged
tomaszbk merged 2 commits into
mainfrom
render/catalog-without-memory
Nov 16, 2026
Merged

tomaszbk merged 2 commits into
mainfrom
render/catalog-without-memory

Conversation

@5hif7y

@5hif7y 5hif7y commented Nov 16, 2026

Copy link
Copy Markdown
Member

Closes #88.

Why it failed

abi.SHADER_CATALOG_VERSION is 3, and catalog_valid refuses any other version. Two render fixtures still wrote "version":2:

  • MEMORY_CATALOG (render/memory_test.odin): program_catalog_parse never succeeded, with memory or without, so the Catalog case of renderer_calls_without_memory_are_refused_and_keep_what_they_had never went through. That is the failure of renderer_calls_without_memory_are_refused_and_keep_what_they_had fails on main #88, and why it failed with --no-gpu too.
  • broken (render/scene_edit_test.odin): the catalog was refused for its version, so "a parameter past the 256 bytes of a row makes the catalog invalid" passed without testing the offset.

Changes

Both fixtures say "version":3. Tests only, 2 lines.

Tests

  • mirai test render --no-gpu: 97/97.
  • Both tests with the GPU (RX 580): pass.
  • The broken catalog with its parameter moved to offset 0 now parses, and the test fails as it should, so it checks the offset again.

🤖 Generated with Claude Code

The shader catalog is at version 3, and two fixtures still said 2:
renderer_calls_without_memory_are_refused_and_keep_what_they_had never
parsed its catalog, even with memory, and the wide-parameter check of
program_catalog_names_the_programs_and_packs_their_parameters passed
because of the version rather than the offset it tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@5hif7y 5hif7y self-assigned this Nov 16, 2026
@5hif7y
5hif7y requested a review from tomaszbk November 16, 2026 00:05
The fixtures hold only their programs; catalog_text wraps them with
abi.SHADER_CATALOG_VERSION, so a new version of the catalog does not leave the
tests of an invalid catalog passing for the version alone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tomaszbk
tomaszbk merged commit bc32cd8 into main Nov 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

renderer_calls_without_memory_are_refused_and_keep_what_they_had fails on main

2 participants