Repository navigation
Give the catalogs of two render tests the version the parser reads - #108
Merged
Merged
Conversation
The shader catalog is at version 3, and two fixtures still said 2: renderer_calls_without_memory_are_refused_and_keep_what_they_had never parsed its catalog, even with memory, and the wide-parameter check of program_catalog_names_the_programs_and_packs_their_parameters passed because of the version rather than the offset it tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The fixtures hold only their programs; catalog_text wraps them with abi.SHADER_CATALOG_VERSION, so a new version of the catalog does not leave the tests of an invalid catalog passing for the version alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #88.
Why it failed
abi.SHADER_CATALOG_VERSIONis 3, andcatalog_validrefuses any other version. Two render fixtures still wrote"version":2:MEMORY_CATALOG(render/memory_test.odin):program_catalog_parsenever succeeded, with memory or without, so theCatalogcase ofrenderer_calls_without_memory_are_refused_and_keep_what_they_hadnever went through. That is the failure ofrenderer_calls_without_memory_are_refused_and_keep_what_they_hadfails onmain#88, and why it failed with--no-gputoo.broken(render/scene_edit_test.odin): the catalog was refused for its version, so "a parameter past the 256 bytes of a row makes the catalog invalid" passed without testing the offset.Changes
Both fixtures say
"version":3. Tests only, 2 lines.Tests
mirai test render --no-gpu: 97/97.brokencatalog with its parameter moved to offset 0 now parses, and the test fails as it should, so it checks the offset again.🤖 Generated with Claude Code