Repository navigation
Find Git Bash through git --exec-path in mirai.cmd and the tool alike - #11
Conversation
|
Needs more testing as a user before merging. The tests and the sessions listed in the description cover the engine side only. My lead and I will adapt it as needed, and tomorrow I will test it with a separate agent acting as a Mirai user. |
|
Review: rework. The branch conflicts in
|
The tool looked only in %ProgramFiles%\Git, so bench compare and mirai measure failed with Git installed elsewhere, and mirai.cmd probed four folders before asking git. Both now take one rule: git --exec-path names <root>/mingw64/libexec/git-core, and Git Bash is <root>/bin/bash.exe. It also finds a Git reached through a shim, such as Scoop's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
0964548 to
ab4a332
Compare
|
Rebuilt on
The PR is now only point 3. Code without tests is +18/−26. Verification (Windows 10, Git in
Not tested: Scoop for real (covered by the test only), Linux and macOS (the |
Closes #8.
Rebuilt on
main8c5a2a6 after the review; the comment below answers it point by point.Changes
Find Git Bash through git --exec-path in mirai.cmd and the tool alike
The tool looked only in %ProgramFiles%\Git, so bench compare and
mirai measure failed with Git installed elsewhere, and mirai.cmd probed
four folders before asking git. Both now take one rule: git --exec-path
names /mingw64/libexec/git-core, and Git Bash is /bin/bash.exe.
It also finds a Git reached through a shim, such as Scoop's.
Merge order
Independent: any order. All six PRs were merged together onto
mainwith no conflict, and the steps ofchecks.ymlpass on that tree (mirai checkon 135 packages, 18 test suites without a GPU).Not tested
shpath is unchanged).🤖 Generated with Claude Code