Skip to content

Keep the launcher responsive while opening projects and refreshing assets - #117

Merged
tomaszbk merged 3 commits into
mainfrom
codex/launcher-async-import
Nov 20, 2026
Merged

tomaszbk merged 3 commits into
mainfrom
codex/launcher-async-import

Conversation

@tomaszbk

@tomaszbk tomaszbk commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Run package refresh as a cancellable subprocess of build.Job, draining stdout/stderr in a bounded loop per poll and preserving importer progress and errors for callers that wait for the build.
  • Preserve debug symbols (.pdb/.dSYM) and stale-file sweeping in job_files_remove once a build publishes (compiled_status == .Built), including if a subsequent package refresh fails or is cancelled.
  • Move launcher/project opening (project.open, build.job_*, build.shaders_*) onto the shared Build_Run background thread with atomic Build_Stage progress (Preparing, Building, Importing, Shaders), non-blocking UI cancel (projects_cancel_request), proper shaders_cancel + shaders_wait on cancellation, and monotonic 5-step modal progress (removing the starting/start_frame frame-delay hack).

Verification

  • macOS ARM64 (28eb43c81):
    • mirai check cook/build, mirai check editor, uv run scripts/check_docs.py (0 problems in 194 Markdown files) and uv run scripts/check_ui_style.py all passed.
    • Focal regressions in cook/build (5 tests: import failure formatting, polling/cancelling held import, debug-file retention & stale cleanup across async import/failure, multi-chunk pipe draining, active-job file preservation) and editor (3 tests: project opening off the UI frame, stage labels, cancel, and Build_Run tests) passed with memory tracking enabled.
    • Real build of templates/empty (mirai build editor templates/empty) passed.
    • Full mirai test cook/build --no-gpu: 122/125 passed; all 3 failures reproduce on main (a_change_inside_a_procedure_links_what_links_against_it_again, a_game_ships_the_settings_of_the_engine_and_of_its_project_merged, no_store_of_an_aggregate_of_more_than_64_bytes, with 0 aggregate-store issues in touched files).
    • Full mirai test editor --no-gpu: 398/400 passed; 2 unrelated failures (asset_import_reads_a_relative_source_from_the_project Windows drive path on macOS, and ai_connections_check_keeps_its_popup_and_update_starts_without_confirmation under load).
  • Windows CI (checks workflow) will verify Windows build & CPU suites on the pushed head.

@tomaszbk
tomaszbk marked this pull request as ready for review November 20, 2026 13:16
@tomaszbk tomaszbk changed the title Keep the launcher responsive while refreshing assets Keep the launcher responsive while opening projects and refreshing assets Nov 20, 2026
@tomaszbk
tomaszbk merged commit 0b64153 into main Nov 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant