Repository navigation
Keep the launcher responsive while opening projects and refreshing assets - #117
Merged
Merged
Conversation
tomaszbk
marked this pull request as ready for review
November 20, 2026 13:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build.Job, draining stdout/stderr in a bounded loop per poll and preserving importer progress and errors for callers that wait for the build..pdb/.dSYM) and stale-file sweeping injob_files_removeonce a build publishes (compiled_status == .Built), including if a subsequent package refresh fails or is cancelled.project.open,build.job_*,build.shaders_*) onto the sharedBuild_Runbackground thread with atomicBuild_Stageprogress (Preparing,Building,Importing,Shaders), non-blocking UI cancel (projects_cancel_request), propershaders_cancel+shaders_waiton cancellation, and monotonic 5-step modal progress (removing thestarting/start_frameframe-delay hack).Verification
28eb43c81):mirai check cook/build,mirai check editor,uv run scripts/check_docs.py(0 problems in 194 Markdown files) anduv run scripts/check_ui_style.pyall passed.cook/build(5 tests: import failure formatting, polling/cancelling held import, debug-file retention & stale cleanup across async import/failure, multi-chunk pipe draining, active-job file preservation) andeditor(3 tests: project opening off the UI frame, stage labels, cancel, andBuild_Runtests) passed with memory tracking enabled.templates/empty(mirai build editor templates/empty) passed.mirai test cook/build --no-gpu: 122/125 passed; all 3 failures reproduce onmain(a_change_inside_a_procedure_links_what_links_against_it_again,a_game_ships_the_settings_of_the_engine_and_of_its_project_merged,no_store_of_an_aggregate_of_more_than_64_bytes, with 0 aggregate-store issues in touched files).mirai test editor --no-gpu: 398/400 passed; 2 unrelated failures (asset_import_reads_a_relative_source_from_the_projectWindows drive path on macOS, andai_connections_check_keeps_its_popup_and_update_starts_without_confirmationunder load).checksworkflow) will verify Windows build & CPU suites on the pushed head.