Repository navigation
Conversation
|
Needs more testing as a user before merging. The tests and the sessions listed in the description cover the engine side only. My lead and I will adapt it as needed, and tomorrow I will test it with a separate agent acting as a Mirai user. |
|
Review: rework. This PR depends on #12. It conflicts with
|
171ee60 to
d26240e
Compare
44c0b17 to
9c23dc6
Compare
|
Rebuilt on top of the new #12, as
Budgets: a Performance section in Baselines: stored as digests in Not tested: Linux and macOS (type-checked only). A user-side test with a separate agent is still pending, as said before. |
|
Follow-up: a live run of
Not covered: a plugin of the project's own ( |
|
Review of the rebuilt branch: this does not fit Mirai as it is. I suggest a much smaller PR. The points of the first review are solved as written (no paired structs, no JSON cut as text, no severities). The problem now is the surface: five new concepts (budgets, baselines, digests, owners, audit) and +310 lines of code without tests, for little new information. What is really new compared with Only three things:
Everything else in the answer is already in the summary of #12: p95, Why the budgets do not work
Other findings
What I would keep, as a new small PR on top of #12
If you think budgets are worth having, they would need to be measured in the player, not in the editor, and live outside the versioned manifest. That is a different design, so let's agree on it in an issue before any code. |
- Step_Info gains plugin and game; the generator writes the steps by field name and tells a package of the game with one check (game_package), which types, records and steps share. - Api_Profile_Zone gains owner (Game, Plugin, Engine) and plugin, found once per capture from Step_Info. GPU passes have none: a pass does not know who added it. - profile.save keeps what profile.compare reads of a capture as a baseline of the project, by name, in .mirai/profiles/baselines; profile.compare takes baseline. The file carries a format version and is validated: a corrupt one or one of another version is refused. profile.list names the baselines. - Generator tests find a step's row by name and check only its fields. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
9c23dc6 to
b04fd42
Compare
|
Rebuilt as the small PR you proposed. b04fd42, from
Budgets measured in the player are not proposed here. |
|
Review of the rebuilt branch: ready after small fixes. This is exactly the scope we agreed on, thank you. Nothing of audit, budgets, Project Settings or the manifest is left, the game check lives in one place, and baselines have a version, a name check and a test with a corrupt file. To fix before the merge
Smaller points
|
Closes #9.
Rebuilt after the second review as the small PR it proposed.
profile.audit, the budgets and the Performance section of the manifest and Project Settings are gone. What is left is whatprofile.capture+profile.comparedid not give: the owner of a zone, and baselines that outlive the session.Changes
Step_Infogainspluginandgame.game_package) that types, records and steps share.Api_Profile_Zonegainsowner(Game,Plugin,Engine) andplugin, found once per capture fromStep_Info.profile.save {id, name}keeps whatprofile.comparereads of a capture, as a baseline of the project, in.mirai/profiles/baselines.profile.comparetakesbaseline, andprofile.listnames the baselines.Code without tests: +217/−53.
editor/profile_baseline.odinis 122 of that, andeditor/api_profile.odinis +58/−47 because compare now reads a stored summary of each capture. Tests: +92/−7.Tests
mirai checkpasses for core, cook/build, editor, project and the profiler plugin.a_baseline_keeps_what_compare_reads_and_refuses_another_file(a baseline saved and read back, plus a corrupt file, an invalid one, an old one with no version and one of a newer version).mirai test editor --no-gpu: 378/378.mirai test cook/build: the three rewritten generator tests pass.mainb33d9a2. Four fixtures are missing thecompressorcollection (Fourcook/buildtests fail onmain: their fixture engine has nocompressorcollection #95), andterrainstores an aggregate of 320 bytes (terrain::source_edit_layer_addstores a 320-byte aggregate at once, whichno_store_of_an_aggregate_of_more_than_64_bytesrefuses #96).demo:Game, 35Pluginand 21Engine;profile.savewrotebefore.jsonwith"version": 1;profile.listnamed it.Not tested
demohas none.--copysession of this worktree: its build fails on a path over Windows' 260-character limit (A--copysession fails to build on Windows when a shader path passes 260 characters #97).🤖 Generated with Claude Code